From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adam Jackson <ajax@redhat.com>
Subject: Re: [Intel-gfx] [PATCH 09/12] drm/edid: Update range descriptor
	struct	for EDID 1.4
Date: Tue, 17 Apr 2012 13:17:31 -0400
Message-ID: <1334683051.32618.0.camel@atropine>
References: <1334349220-13814-1-git-send-email-ajax@redhat.com>
	<1334349220-13814-10-git-send-email-ajax@redhat.com>
	<s5h3982qt22.wl%tiwai@suse.de>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0400267001=="
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
In-Reply-To: <s5h3982qt22.wl%tiwai@suse.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Takashi Iwai <tiwai@suse.de>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org


--===============0400267001==
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-U7g7+O8z3nsS64JCxDrI"


--=-U7g7+O8z3nsS64JCxDrI
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2012-04-17 at 17:25 +0200, Takashi Iwai wrote:
> At Fri, 13 Apr 2012 16:33:37 -0400, Adam Jackson wrote:
> > +	u8 flags;
> > +	union {
> > +		struct {
> > +			u8 reserved;
> > +			u8 hfreq_start_khz; /* need to multiply by 2 */
> > +			u8 c; /* need to divide by 2 */
> > +			__le16 m;
> > +			u8 k;
> > +			u8 j; /* need to divide by 2 */
> > +		} gtf2;
> > +		struct {
> > +			u8 version;
> > +			u8 data1; /* high 6 bits: extra clock resolution */
> > +			u8 data2; /* plus low 2 of above: max hactive */
> > +			u8 supported_aspects;
> > +			u8 flags; /* preferred aspect and blanking support */
> > +			u8 supported_scalings;
> > +			u8 preferred_refresh;
> > +		} cvt;
>=20
> These new structs must be marked with __attribute__((packed)) although
> the struct detailed_data_monitor_range itself is already marked.  At
> least, with gcc 4.6 and x86-64 here, they get unaligned.

Eek.  Good catch, thanks.

- ajax

--=-U7g7+O8z3nsS64JCxDrI
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEABECAAYFAk+NpasACgkQW4otUKDs0NNZcwCfaoTr+w5en6iunB2bN2ZD2Tgl
hhQAoI52t1wEfSNMdnqm9C48CoKIanl1
=TJ3b
-----END PGP SIGNATURE-----

--=-U7g7+O8z3nsS64JCxDrI--


--===============0400267001==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

--===============0400267001==--