From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751865Ab2DRHx0 (ORCPT ); Wed, 18 Apr 2012 03:53:26 -0400 Received: from mx2.parallels.com ([64.131.90.16]:54877 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543Ab2DRHxY (ORCPT ); Wed, 18 Apr 2012 03:53:24 -0400 From: James Bottomley To: Linus Torvalds CC: "Martin K. Petersen" , Jens Axboe , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Subject: Re: USB storage SCSI EH oops Thread-Topic: USB storage SCSI EH oops Thread-Index: AQHNGoyLQYsfnt9fzkSbpcIofu9OGJabXHwAgAAFVYCABU8SgA== Date: Wed, 18 Apr 2012 07:53:20 +0000 Message-ID: <1334735599.4410.17.camel@dabdike> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [195.214.232.10] Content-Type: text/plain; charset="utf-8" Content-ID: <754F7A0A29A58843A6C900868200244A@sw.swsoft.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id q3I7rUQZ017147 On Sat, 2012-04-14 at 15:49 -0700, Linus Torvalds wrote: > On Sat, Apr 14, 2012 at 3:29 PM, Linus Torvalds > wrote: > > > > Confirmed. > > > > I tested twice: with that patch, the oops is repeatable, and happens > > something like 30 seconds after plugging in the USB thing into the > > monitor. > > > > With that patch reverted, the thing still doesn't *work*, but I don't > > get the oops. Instead, I get the appended noise in my dmesg.. > > .. and the reason that card reader has trouble seems to be that it's > just too damn old, and doesn't understand SD-HC cards. It works fine > with old SD cards. > > So the reader is fine (well, apart from being too old), USB-storage is > fine, but the SCSI error handler is broken. > > Even with that commit reverted, once the SCSI layer has decided to > off-line the device, you can't get it back, even if you remove the > media and insert a non-HC SD card. You have to unplug and re-plug the > reader. That seems to be a slight misfeature of SCSI error handling, > but compared to oopsing, it's minor. OK, will either queue the update or a revert. Just on the offline device problem; after it's offlined, can you get it back with echo running > /sys/block/sd/device/state ? That would show we're failing to recognise the device as removable media which is gone. James {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I