From: Bastian Hecht <hechtb@googlemail.com>
To: linux-mtd@lists.infradead.org
Cc: Bastian Hecht <hechtb@gmail.com>
Subject: [RFC] mtd: nand: Add a STATUS CMD after write verification
Date: Wed, 18 Apr 2012 12:20:04 +0200 [thread overview]
Message-ID: <1334744404-721-1-git-send-email-hechtb@gmail.com> (raw)
When using CONFIG_MTD_NAND_VERIFY_WRITE=y an extra read command is sent
to the NAND chip after writing a page. We need an extra status command
to avoid hick-ups that lead to page write failures.
---
Hello all,
I'm experiencing problems with my current setup and
CONFIG_MTD_NAND_VERIFY_WRITE=y. Usually the command sequence is like
0x70 Status read
0x80 0x10 Page prog
0x70
0x80 0x10 Page prog
0x70
...
When activating write verification there is a read command before the
page prog.
0x80 0x10
0x70
0x0 read
0x80 0x10
0x70
...
This makes my chip write garbage, while the patch fixes it.
Now I wonder if this problem is caused by my NAND chip only, or if this
is a general problem that should be adressed.
---
drivers/mtd/nand/nand_base.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 8a393f9..62d6691 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2101,6 +2101,8 @@ static int nand_write_page(struct mtd_info *mtd, struct nand_chip *chip,
if (chip->verify_buf(mtd, buf, mtd->writesize))
return -EIO;
+
+ chip->cmdfunc(mtd, NAND_CMD_STATUS, -1, -1);
#endif
return 0;
}
--
1.7.5.4
next reply other threads:[~2012-04-18 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 10:20 Bastian Hecht [this message]
2012-04-18 10:25 ` [RFC] mtd: nand: Add a STATUS CMD after write verification Bastian Hecht
2012-04-27 5:54 ` Artem Bityutskiy
2012-04-27 10:17 ` Bastian Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334744404-721-1-git-send-email-hechtb@gmail.com \
--to=hechtb@googlemail.com \
--cc=hechtb@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.