From: Mike Brudevold <puffy.taco@gmail.com>
To: ofono@ofono.org
Subject: [PATCH] voicecall: fix release and answer existing call validation
Date: Thu, 19 Apr 2012 17:10:43 -0500 [thread overview]
Message-ID: <1334873443-21124-1-git-send-email-puffy.taco@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
From: Michael Brudevold <michael.brudevold@logicpd.com>
Release and answer should be allowed when there are held calls as well as the
existing check for waiting calls. Most implementations use AT+CHLD=1 which
will resume the other call, be it waiting or held. This follows the HFP,
GSM 07.07 and 3GPP 27.007 specs.
---
src/voicecall.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/voicecall.c b/src/voicecall.c
index 263f1ee..2d261bf 100644
--- a/src/voicecall.c
+++ b/src/voicecall.c
@@ -1684,7 +1684,7 @@ static DBusMessage *manager_release_and_answer(DBusConnection *conn,
if (vc->pending || vc->dial_req || vc->pending_em)
return __ofono_error_busy(msg);
- if (!voicecalls_have_waiting(vc))
+ if (!(voicecalls_have_waiting(vc) || voicecalls_have_held(vc)))
return __ofono_error_failed(msg);
if (vc->driver->release_all_active == NULL)
--
1.7.5.4
next reply other threads:[~2012-04-19 22:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 22:10 Mike Brudevold [this message]
2012-04-19 13:42 ` [PATCH] voicecall: fix release and answer existing call validation Denis Kenzior
2012-04-21 1:34 ` Mike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334873443-21124-1-git-send-email-puffy.taco@gmail.com \
--to=puffy.taco@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.