From: Bastian Hecht <hechtb@googlemail.com>
To: linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
Laurent Pichart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH 5/9] mtd: sh_flctl: Simplify the hardware ecc page read/write
Date: Fri, 20 Apr 2012 11:13:46 +0200 [thread overview]
Message-ID: <1334913230-23615-6-git-send-email-hechtb@gmail.com> (raw)
In-Reply-To: <1334913230-23615-1-git-send-email-hechtb@gmail.com>
As the equation mtd->writesize == eccsteps * eccsize holds, we can
simplify the code. The second loop of the 1st hunk is never entered,
so we delete it.
Signed-off-by: Bastian Hecht <hechtb@gmail.com>
---
drivers/mtd/nand/sh_flctl.c | 25 ++-----------------------
1 files changed, 2 insertions(+), 23 deletions(-)
diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index c16479c..8e56f87 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -353,35 +353,14 @@ static void set_cmd_regs(struct mtd_info *mtd, uint32_t cmd, uint32_t flcmcdr_va
static int flctl_read_page_hwecc(struct mtd_info *mtd, struct nand_chip *chip,
uint8_t *buf, int page)
{
- int i, eccsize = chip->ecc.size;
- int eccbytes = chip->ecc.bytes;
- int eccsteps = chip->ecc.steps;
- uint8_t *p = buf;
- struct sh_flctl *flctl = mtd_to_flctl(mtd);
-
- for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize)
- chip->read_buf(mtd, p, eccsize);
-
- for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize) {
- if (flctl->hwecc_cant_correct[i])
- mtd->ecc_stats.failed++;
- else
- mtd->ecc_stats.corrected += 0;
- }
-
+ chip->read_buf(mtd, buf, mtd->writesize);
return 0;
}
static void flctl_write_page_hwecc(struct mtd_info *mtd, struct nand_chip *chip,
const uint8_t *buf)
{
- int i, eccsize = chip->ecc.size;
- int eccbytes = chip->ecc.bytes;
- int eccsteps = chip->ecc.steps;
- const uint8_t *p = buf;
-
- for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize)
- chip->write_buf(mtd, p, eccsize);
+ chip->write_buf(mtd, buf, mtd->writesize);
}
static void execmd_read_page_sector(struct mtd_info *mtd, int page_addr)
--
1.7.5.4
WARNING: multiple messages have this Message-ID (diff)
From: Bastian Hecht <hechtb@googlemail.com>
To: linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
Laurent Pichart <laurent.pinchart@ideasonboard.com>
Subject: [PATCH 5/9] mtd: sh_flctl: Simplify the hardware ecc page read/write
Date: Fri, 20 Apr 2012 09:13:46 +0000 [thread overview]
Message-ID: <1334913230-23615-6-git-send-email-hechtb@gmail.com> (raw)
In-Reply-To: <1334913230-23615-1-git-send-email-hechtb@gmail.com>
As the equation mtd->writesize = eccsteps * eccsize holds, we can
simplify the code. The second loop of the 1st hunk is never entered,
so we delete it.
Signed-off-by: Bastian Hecht <hechtb@gmail.com>
---
drivers/mtd/nand/sh_flctl.c | 25 ++-----------------------
1 files changed, 2 insertions(+), 23 deletions(-)
diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
index c16479c..8e56f87 100644
--- a/drivers/mtd/nand/sh_flctl.c
+++ b/drivers/mtd/nand/sh_flctl.c
@@ -353,35 +353,14 @@ static void set_cmd_regs(struct mtd_info *mtd, uint32_t cmd, uint32_t flcmcdr_va
static int flctl_read_page_hwecc(struct mtd_info *mtd, struct nand_chip *chip,
uint8_t *buf, int page)
{
- int i, eccsize = chip->ecc.size;
- int eccbytes = chip->ecc.bytes;
- int eccsteps = chip->ecc.steps;
- uint8_t *p = buf;
- struct sh_flctl *flctl = mtd_to_flctl(mtd);
-
- for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize)
- chip->read_buf(mtd, p, eccsize);
-
- for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize) {
- if (flctl->hwecc_cant_correct[i])
- mtd->ecc_stats.failed++;
- else
- mtd->ecc_stats.corrected += 0;
- }
-
+ chip->read_buf(mtd, buf, mtd->writesize);
return 0;
}
static void flctl_write_page_hwecc(struct mtd_info *mtd, struct nand_chip *chip,
const uint8_t *buf)
{
- int i, eccsize = chip->ecc.size;
- int eccbytes = chip->ecc.bytes;
- int eccsteps = chip->ecc.steps;
- const uint8_t *p = buf;
-
- for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize)
- chip->write_buf(mtd, p, eccsize);
+ chip->write_buf(mtd, buf, mtd->writesize);
}
static void execmd_read_page_sector(struct mtd_info *mtd, int page_addr)
--
1.7.5.4
next prev parent reply other threads:[~2012-04-20 9:14 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 9:13 [PATCH 0/9] sh_flctl hardware ECC mode cleanup Bastian Hecht
2012-04-20 9:13 ` Bastian Hecht
2012-04-20 9:13 ` [PATCH 1/9] mtd: sh_flctl: Add support for error IRQ Bastian Hecht
2012-04-20 9:13 ` Bastian Hecht
2012-04-21 14:29 ` Laurent Pinchart
2012-04-21 14:29 ` Laurent Pinchart
2012-04-23 8:41 ` Bastian Hecht
2012-04-23 8:41 ` Bastian Hecht
2012-04-20 9:13 ` [PATCH 2/9] ARM: sh-mobile: mackerel: Add error IRQ resource Bastian Hecht
2012-04-20 9:13 ` Bastian Hecht
2012-04-21 14:30 ` Laurent Pinchart
2012-04-21 14:30 ` Laurent Pinchart
2012-04-23 8:43 ` Bastian Hecht
2012-04-23 8:43 ` Bastian Hecht
2012-04-20 9:13 ` [PATCH 3/9] mtd: sh_flctl: Use different OOB layout Bastian Hecht
2012-04-20 9:13 ` Bastian Hecht
2012-04-21 14:41 ` Laurent Pinchart
2012-04-21 14:41 ` Laurent Pinchart
2012-04-23 8:51 ` Bastian Hecht
2012-04-23 8:51 ` Bastian Hecht
2012-04-20 9:13 ` [PATCH 4/9] mtd: sh_flctl: Fix hardware ECC behaviour Bastian Hecht
2012-04-20 9:13 ` Bastian Hecht
2012-04-20 9:13 ` Bastian Hecht [this message]
2012-04-20 9:13 ` [PATCH 5/9] mtd: sh_flctl: Simplify the hardware ecc page read/write Bastian Hecht
2012-04-20 9:13 ` [PATCH 6/9] mtd: sh_flctl: Group sector accesses into a single transfer Bastian Hecht
2012-04-20 9:13 ` Bastian Hecht
2012-04-20 9:13 ` [PATCH 7/9] mtd: sh_flctl: Restructure the hardware ECC handling Bastian Hecht
2012-04-20 9:13 ` Bastian Hecht
2012-04-20 9:13 ` [PATCH 8/9] mtd: sh_flctl: Use user oob data in hardware ECC mode Bastian Hecht
2012-04-20 9:13 ` Bastian Hecht
2012-04-21 15:00 ` Laurent Pinchart
2012-04-21 15:00 ` Laurent Pinchart
2012-04-23 9:05 ` Bastian Hecht
2012-04-23 9:05 ` Bastian Hecht
2012-04-23 9:36 ` Bastian Hecht
2012-04-23 9:36 ` Bastian Hecht
2012-04-24 9:33 ` Laurent Pinchart
2012-04-24 9:33 ` Laurent Pinchart
2012-04-25 4:01 ` Brian Norris
2012-04-25 4:01 ` Brian Norris
2012-04-25 13:26 ` Bastian Hecht
2012-04-25 13:26 ` Bastian Hecht
2012-04-20 9:13 ` [PATCH 9/9] ARM: sh-mobile: mackerel: Use hardware error correction Bastian Hecht
2012-04-20 9:13 ` Bastian Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334913230-23615-6-git-send-email-hechtb@gmail.com \
--to=hechtb@googlemail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.