All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>,
	Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915: rc6 residency (fix the fix)
Date: Fri, 20 Apr 2012 20:24:04 +0100	[thread overview]
Message-ID: <1334949869_7667@CP5-2952> (raw)
In-Reply-To: <1334947801-17280-1-git-send-email-ben@bwidawsk.net>

On Fri, 20 Apr 2012 11:50:01 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> Chris' fix for my 32b breakage was incorrect. do_div returns a
> remainder. Go back to a divide macro which is more 32b friendly.
> 
> Tested on x86-64.
> 
> This has only been compile tested on 32b systems.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48756
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>
Sincere-apologies: Chris Wilson <chris@chris-wilson.co.uk>

Had I looked for the equivalent 64bit DIV_ROUND_UP, I could have saved
myself some embarrassment.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2012-04-20 19:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 18:50 [PATCH] drm/i915: rc6 residency (fix the fix) Ben Widawsky
2012-04-20 19:24 ` Chris Wilson [this message]
2012-04-20 19:27   ` Daniel Vetter
2012-04-22 15:49 ` Chris Wilson
2012-04-22 17:35   ` Ben Widawsky
2012-04-22 17:39     ` Chris Wilson
2012-04-22 18:02       ` Ben Widawsky
2012-04-22 18:11         ` Chris Wilson
2012-04-23  2:57       ` Ben Widawsky
2012-04-23  7:38         ` Daniel Vetter
  -- strict thread matches above, loose matches on Subject: below --
2012-04-22 18:27 Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334949869_7667@CP5-2952 \
    --to=chris@chris-wilson.co.uk \
    --cc=ben@bwidawsk.net \
    --cc=benjamin.widawsky@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.