From: Chris Wilson <chris@chris-wilson.co.uk>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: rip out unnecessary calls to drm_mode_set_crtcinfo
Date: Tue, 24 Apr 2012 16:11:43 +0100 [thread overview]
Message-ID: <1335280337_38538@CP5-2952> (raw)
In-Reply-To: <1335274897-18352-1-git-send-email-daniel.vetter@ffwll.ch>
On Tue, 24 Apr 2012 15:41:37 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> the only places we actually need the crtc timings is in the mode_set
> function.
>
> So we can now safely rip out all the remaining calls to set_crtcinfo
> left in the driver and clean up this confusion.
I have a little flicker of doubt because these tend to end up being
passed into the core drm as well as used during modeset. Even looking
through the instances of drm_mode_set_crtcinfo() in the core, I'm left
no the wiser as to which functions expect crtc_* to be filled in. As far
I can see the only place where set_crtcinfo() must be called is prior to
the final modeset, and so the crtc_* values are only ever used on the
adjusted_mode. Hence why the drm usage leaves me slightly puzzled.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-04-24 15:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 13:41 [PATCH] drm/i915: rip out unnecessary calls to drm_mode_set_crtcinfo Daniel Vetter
2012-04-24 15:11 ` Chris Wilson [this message]
2012-04-24 15:37 ` Daniel Vetter
2012-05-03 14:26 ` Chris Wilson
2012-05-03 13:51 ` Daniel Vetter
2012-05-04 9:33 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335280337_38538@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.