From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/edid: Try harder to fix up base EDID blocks Date: Tue, 24 Apr 2012 20:13:59 +0100 Message-ID: <1335294871_40532@CP5-2952> References: <1334587208-11772-1-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D6D6A0A32 for ; Tue, 24 Apr 2012 12:14:37 -0700 (PDT) In-Reply-To: <1334587208-11772-1-git-send-email-ajax@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Adam Jackson , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, 16 Apr 2012 10:40:08 -0400, Adam Jackson wrote: > Requiring the first byte of the EDID base block header to be 0 means we > don't fix up as many transfer errors as we could. Instead have the > callers specify whether it's meant to be block 0 or not, and > conditionally run header fixup based on that. > > Bugzilla: https://bugzilla.redhat.com/812890 > Signed-off-by: Adam Jackson The patch does watch it says on the tin. I don't pretend to know how frequent this corruption is, but as it stands the current code fails to be as effective as it could be. Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre