From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [PATCH] mgag200: initial g200se driver Date: Thu, 26 Apr 2012 11:01:17 -0400 Message-ID: <1335452477.2091.17.camel@atropine> References: <1335448125-17955-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1186364416==" Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 623019ECF9 for ; Thu, 26 Apr 2012 08:01:19 -0700 (PDT) In-Reply-To: <1335448125-17955-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1186364416== Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-fG5akEDD67Dfg1s/yUuV" --=-fG5akEDD67Dfg1s/yUuV Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2012-04-26 at 14:48 +0100, Dave Airlie wrote: > +/* > + * Our emulated hardware has two sets of memory. One is video RAM and ca= n > + * simply be used as a linear framebuffer - the other provides mmio acce= ss > + * to the display registers. The latter can also be accessed via IO port > + * access, but we map the range and use mmio to program them instead > + */ I suspect this comment came from somewhere near the emulated cirrus card in qemu? G200's definitely not emulated hardware. > +/* > + * The meat of this driver. The core passes us a mode and we have to pro= gram > + * it. The modesetting here is the bare minimum required to satisfy the = qemu > + * emulation of this hardware, and running this against a real device is > + * likely to result in an inadequately programmed mode. We've already ha= d > + * the opportunity to modify the mode, so whatever we receive here shoul= d > + * be something that can be correctly programmed and displayed > + */ Yep, drm/cirrus all over the place here. > +/* > + * This is called after a mode is programmed. It should reverse anything= done > + * by the prepare function > + */ > +static void mga_crtc_commit(struct drm_crtc *crtc) > +{ This appears to be missing the analog of the "Reset tagfifo" commit from the X driver for G200ER: http://cgit.freedesktop.org/xorg/driver/xf86-video-mga/commit/?id=3D01ca218= 6ea028b2549de509b51726aa08519fce0 Which, admittedly, is in an odd place in the X driver. - ajax --=-fG5akEDD67Dfg1s/yUuV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAk+ZYz0ACgkQW4otUKDs0NNO0wCgjqOHZ/OyE/0QrVLUTjqKZY7l TPsAnRTxzHfP3m3rKcqMlzS71ezT1vcF =W3j1 -----END PGP SIGNATURE----- --=-fG5akEDD67Dfg1s/yUuV-- --===============1186364416== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1186364416==--