From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/5] ASoC: dpcm: Add debugFS support for DPCM
Date: Thu, 26 Apr 2012 17:57:29 +0100 [thread overview]
Message-ID: <1335459449.4950.1.camel@odin> (raw)
In-Reply-To: <20120426164454.GM3207@opensource.wolfsonmicro.com>
On Thu, 2012-04-26 at 17:44 +0100, Mark Brown wrote:
> On Wed, Apr 25, 2012 at 12:12:50PM +0100, Liam Girdwood wrote:
>
> I've queued this to apply this but a few nits I noticed:
>
> > +#ifdef CONFIG_DEBUG_FS
> > + dpcm->debugfs_state = debugfs_create_u32(be->dai_link->name, 0644,
> > + fe->debugfs_dpcm_root, &dpcm->state);
> > +#endif
>
> I have to say that this being writable seems rather scary... any great
> need for that?
Ah, no - will fix this and the other two incrementally.
Regards
Liam
next prev parent reply other threads:[~2012-04-26 16:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 11:12 [PATCH 1/5] ASoC: dpcm: Add Dynamic PCM core operations Liam Girdwood
2012-04-25 11:12 ` [PATCH 2/5] ASoC: dpcm: Add debugFS support for DPCM Liam Girdwood
2012-04-26 16:44 ` Mark Brown
2012-04-26 16:57 ` Liam Girdwood [this message]
2012-04-25 11:12 ` [PATCH 3/5] ASoC: dpcm: Add runtime dynamic route update Liam Girdwood
2012-04-25 11:12 ` [PATCH 4/5] ASoC: dpcm: Add bespoke trigger() Liam Girdwood
2012-04-25 11:12 ` [PATCH 5/5] ASoC: dpcm: Add API for DAI link substream and runtime lookup Liam Girdwood
2012-04-26 16:54 ` [PATCH 1/5] ASoC: dpcm: Add Dynamic PCM core operations Mark Brown
2012-04-26 17:04 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335459449.4950.1.camel@odin \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.