From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [PATCH 2/2] drm/nouveau: implement precise vblank timestamping Date: Thu, 26 Apr 2012 23:31:24 +0200 Message-ID: <1335475884.2645.4.camel@tellur> References: <1335392782-2141-1-git-send-email-dev@lynxeye.de> <1335392782-2141-2-git-send-email-dev@lynxeye.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Maarten Maathuis Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Ben Skeggs , Kleiner , Mario-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org List-Id: nouveau.vger.kernel.org Hi Maarten, Am Donnerstag, den 26.04.2012, 23:25 +0200 schrieb Maarten Maathuis: > It seems a bit strange to go in between a register and defines that > probably belong to that register. > Yes, you are right. Thanks for catching this. I will fix this up, but will wait for Ben's comments and/or other review feedback before spamming the list with just another version of this patch. -- Lucas > On Thu, Apr 26, 2012 at 12:26 AM, Lucas Stach wrote: > > #define NV_PCRTC_ENGINE_CTRL 0x00600860 > > +#define NV_PCRTC_STAT(i0) (0x00600868 + 0x2000*(i0)) > > # define NV_CRTC_FSEL_I2C (1 << 4) > > # define NV_CRTC_FSEL_OVERLAY (1 << 12) > > >