diff for duplicates of <1335869133.13683.125.camel@twins> diff --git a/a/content_digest b/N1/content_digest index 5dbc88e..e40d75c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,8 +3,26 @@ "ref\020120426165911.00cebd31.akpm@linux-foundation.org\0" "From\0Peter Zijlstra <a.p.zijlstra@chello.nl>\0" "Subject\0Re: [PATCH 1/9] cpu: Introduce clear_tasks_mm_cpumask() helper\0" - "Date\0Tue, 01 May 2012 10:45:33 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Tue, 01 May 2012 12:45:33 +0200\0" + "To\0Andrew Morton <akpm@linux-foundation.org>\0" + "Cc\0Anton Vorontsov <anton.vorontsov@linaro.org>" + Oleg Nesterov <oleg@redhat.com> + Russell King <linux@arm.linux.org.uk> + Mike Frysinger <vapier@gentoo.org> + Benjamin Herrenschmidt <benh@kernel.crashing.org> + Richard Weinberger <richard@nod.at> + Paul Mundt <lethal@linux-sh.org> + KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> + John Stultz <john.stultz@linaro.org> + linux-arm-kernel@lists.infradead.org + linux-kernel@vger.kernel.org + uclinux-dist-devel@blackfin.uclinux.org + linuxppc-dev@lists.ozlabs.org + linux-sh@vger.kernel.org + user-mode-linux-devel@lists.sourceforge.net + linaro-kernel@lists.linaro.org + patches@linaro.org + " linux-mm@kvack.org\0" "\00:1\0" "b\0" "On Thu, 2012-04-26 at 16:59 -0700, Andrew Morton wrote:\n" @@ -59,4 +77,4 @@ "> > + rcu_read_unlock();\n" > > +} -43017867f83d80176ac1573905825c1abdb28b1e9e8529705781a724468681cc +927e81a8cdf3d2c2e5d6eea8ad5fb887d578834c0ea71029a2722ffb5b63c02d
diff --git a/a/1.txt b/N2/1.txt index c2b4090..401da90 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,27 +1,27 @@ On Thu, 2012-04-26 at 16:59 -0700, Andrew Morton wrote: > > +void clear_tasks_mm_cpumask(int cpu) -> +>=20 > The operation of this function was presumably obvious to you at the > time you wrote it, but that isn't true of other people at later times. -> +>=20 > Please document it? -> -> +>=20 +>=20 > > +{ > > + struct task_struct *p; > > + > > + /* > > + * This function is called after the cpu is taken down and marked > > + * offline, -> +>=20 > hm, well. Who said that this function will only ever be called > after that CPU was taken down? There is nothing in the function name > nor in the (absent) documentation which enforces this precondition. -> +>=20 > If someone tries to use this function for a different purpose, or > copies-and-modifies it for a different purpose, we just shot them in > the foot. -> +>=20 > They'd be pretty dumb to do that without reading the local comment, > but still... @@ -31,7 +31,7 @@ Methinks something simple like: Ought to cure that worry, no? :-) -> +>=20 > > so its not like new tasks will ever get this cpu set in > > + * their mm mask. -- Peter Zijlstra > > + * Thus, we may use rcu_read_lock() here, instead of grabbing @@ -41,11 +41,11 @@ Ought to cure that worry, no? :-) > > + for_each_process(p) { > > + struct task_struct *t; > > + -> > + t = find_lock_task_mm(p); +> > + t =3D find_lock_task_mm(p); > > + if (!t) > > + continue; > > + cpumask_clear_cpu(cpu, mm_cpumask(t->mm)); > > + task_unlock(t); > > + } > > + rcu_read_unlock(); -> > +} +> > +}=20 diff --git a/a/content_digest b/N2/content_digest index 5dbc88e..eda557e 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,34 +3,51 @@ "ref\020120426165911.00cebd31.akpm@linux-foundation.org\0" "From\0Peter Zijlstra <a.p.zijlstra@chello.nl>\0" "Subject\0Re: [PATCH 1/9] cpu: Introduce clear_tasks_mm_cpumask() helper\0" - "Date\0Tue, 01 May 2012 10:45:33 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Tue, 01 May 2012 12:45:33 +0200\0" + "To\0Andrew Morton <akpm@linux-foundation.org>\0" + "Cc\0linaro-kernel@lists.linaro.org" + Mike Frysinger <vapier@gentoo.org> + user-mode-linux-devel@lists.sourceforge.net + linux-sh@vger.kernel.org + Richard Weinberger <richard@nod.at> + linuxppc-dev@lists.ozlabs.org + Oleg Nesterov <oleg@redhat.com> + linux-kernel@vger.kernel.org + linux-mm@kvack.org + Anton Vorontsov <anton.vorontsov@linaro.org> + Paul Mundt <lethal@linux-sh.org> + John Stultz <john.stultz@linaro.org> + patches@linaro.org + KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> + Russell King <linux@arm.linux.org.uk> + uclinux-dist-devel@blackfin.uclinux.org + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, 2012-04-26 at 16:59 -0700, Andrew Morton wrote:\n" "> > +void clear_tasks_mm_cpumask(int cpu)\n" - "> \n" + ">=20\n" "> The operation of this function was presumably obvious to you at the\n" "> time you wrote it, but that isn't true of other people at later times.\n" - "> \n" + ">=20\n" "> Please document it?\n" - "> \n" - "> \n" + ">=20\n" + ">=20\n" "> > +{\n" "> > + struct task_struct *p;\n" "> > +\n" "> > + /*\n" "> > + * This function is called after the cpu is taken down and marked\n" "> > + * offline,\n" - "> \n" + ">=20\n" "> hm, well. Who said that this function will only ever be called\n" "> after that CPU was taken down? There is nothing in the function name\n" "> nor in the (absent) documentation which enforces this precondition.\n" - "> \n" + ">=20\n" "> If someone tries to use this function for a different purpose, or\n" "> copies-and-modifies it for a different purpose, we just shot them in\n" "> the foot.\n" - "> \n" + ">=20\n" "> They'd be pretty dumb to do that without reading the local comment,\n" "> but still...\n" "\n" @@ -40,7 +57,7 @@ "\n" "Ought to cure that worry, no? :-)\n" "\n" - "> \n" + ">=20\n" "> > so its not like new tasks will ever get this cpu set in\n" "> > + * their mm mask. -- Peter Zijlstra\n" "> > + * Thus, we may use rcu_read_lock() here, instead of grabbing\n" @@ -50,13 +67,13 @@ "> > + for_each_process(p) {\n" "> > + struct task_struct *t;\n" "> > +\n" - "> > + t = find_lock_task_mm(p);\n" + "> > + t =3D find_lock_task_mm(p);\n" "> > + if (!t)\n" "> > + continue;\n" "> > + cpumask_clear_cpu(cpu, mm_cpumask(t->mm));\n" "> > + task_unlock(t);\n" "> > + }\n" "> > + rcu_read_unlock();\n" - > > +} + > > +}=20 -43017867f83d80176ac1573905825c1abdb28b1e9e8529705781a724468681cc +71f3791909c3ffc55e3d40d4a1e3b91ad771e3c21a30ad13c2c08ea57cc9dc81
diff --git a/a/content_digest b/N3/content_digest index 5dbc88e..192362e 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,9 +1,9 @@ "ref\020120423070641.GA27702@lizard\0" "ref\020120423070736.GA30752@lizard\0" "ref\020120426165911.00cebd31.akpm@linux-foundation.org\0" - "From\0Peter Zijlstra <a.p.zijlstra@chello.nl>\0" - "Subject\0Re: [PATCH 1/9] cpu: Introduce clear_tasks_mm_cpumask() helper\0" - "Date\0Tue, 01 May 2012 10:45:33 +0000\0" + "From\0a.p.zijlstra@chello.nl (Peter Zijlstra)\0" + "Subject\0[PATCH 1/9] cpu: Introduce clear_tasks_mm_cpumask() helper\0" + "Date\0Tue, 01 May 2012 12:45:33 +0200\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -59,4 +59,4 @@ "> > + rcu_read_unlock();\n" > > +} -43017867f83d80176ac1573905825c1abdb28b1e9e8529705781a724468681cc +f6c4e9698b31c9e8807b781106d8ced6fd1c802caf0ef1a98250f6d1f33ce67a
diff --git a/a/1.txt b/N4/1.txt index c2b4090..0dc238d 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -48,4 +48,11 @@ Ought to cure that worry, no? :-) > > + task_unlock(t); > > + } > > + rcu_read_unlock(); -> > +} +> > +} + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N4/content_digest index 5dbc88e..2e9f9cf 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -3,8 +3,26 @@ "ref\020120426165911.00cebd31.akpm@linux-foundation.org\0" "From\0Peter Zijlstra <a.p.zijlstra@chello.nl>\0" "Subject\0Re: [PATCH 1/9] cpu: Introduce clear_tasks_mm_cpumask() helper\0" - "Date\0Tue, 01 May 2012 10:45:33 +0000\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "Date\0Tue, 01 May 2012 12:45:33 +0200\0" + "To\0Andrew Morton <akpm@linux-foundation.org>\0" + "Cc\0Anton Vorontsov <anton.vorontsov@linaro.org>" + Oleg Nesterov <oleg@redhat.com> + Russell King <linux@arm.linux.org.uk> + Mike Frysinger <vapier@gentoo.org> + Benjamin Herrenschmidt <benh@kernel.crashing.org> + Richard Weinberger <richard@nod.at> + Paul Mundt <lethal@linux-sh.org> + KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> + John Stultz <john.stultz@linaro.org> + linux-arm-kernel@lists.infradead.org + linux-kernel@vger.kernel.org + uclinux-dist-devel@blackfin.uclinux.org + linuxppc-dev@lists.ozlabs.org + linux-sh@vger.kernel.org + user-mode-linux-devel@lists.sourceforge.net + linaro-kernel@lists.linaro.org + patches@linaro.org + " linux-mm@kvack.org\0" "\00:1\0" "b\0" "On Thu, 2012-04-26 at 16:59 -0700, Andrew Morton wrote:\n" @@ -57,6 +75,13 @@ "> > + task_unlock(t);\n" "> > + }\n" "> > + rcu_read_unlock();\n" - > > +} + "> > +} \n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -43017867f83d80176ac1573905825c1abdb28b1e9e8529705781a724468681cc +e5fcf9452e7f5924281d4a2c87b530cf70913aa8f7856e43b7012377ef8aec1e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.