All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 6/6] nfsd4: fix change attribute endianness
Date: Tue,  1 May 2012 11:45:49 -0400	[thread overview]
Message-ID: <1335887149-30420-7-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1335887149-30420-1-git-send-email-bfields@redhat.com>

From: "J. Bruce Fields" <bfields@redhat.com>

Though actually this doesn't matter much, as NFSv4.0 clients are
required to treat the change attribute as opaque.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 fs/nfsd/nfs4xdr.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index f839be1..61555e7 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -1674,12 +1674,12 @@ nfsd4_decode_compound(struct nfsd4_compoundargs *argp)
 
 static void write32(__be32 **p, u32 n)
 {
-	*(*p)++ = n;
+	*(*p)++ = htonl(n);
 }
 
 static void write64(__be32 **p, u64 n)
 {
-	write32(p, (u32)(n >> 32));
+	write32(p, (n >> 32));
 	write32(p, (u32)n);
 }
 
-- 
1.7.9.5


      parent reply	other threads:[~2012-05-01 15:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-01 15:45 J. Bruce Fields
2012-05-01 15:45 ` [PATCH 1/6] nfsd: state.c should include current_stateid.h J. Bruce Fields
2012-05-01 15:45 ` [PATCH 2/6] nfsd4: fix missing "static" J. Bruce Fields
2012-05-01 15:45 ` [PATCH 3/6] nfsd4: preserve __user annotation on cld downcall msg J. Bruce Fields
2012-05-01 15:53   ` Jeff Layton
2012-05-01 15:45 ` [PATCH 4/6] nfsd4: int/__be32 fixes J. Bruce Fields
2012-05-01 15:45 ` [PATCH 5/6] nfsd4: fix free_stateid return endianness J. Bruce Fields
2012-05-01 15:45 ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335887149-30420-7-git-send-email-bfields@redhat.com \
    --to=bfields@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.