From: Davidlohr Bueso <dave@gnu.org>
To: Karel Zak <kzak@redhat.com>
Cc: Petr Uzel <petr.uzel@suse.cz>, util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH] fdisk: isolate dos label logic
Date: Wed, 02 May 2012 10:56:42 +0200 [thread overview]
Message-ID: <1335949002.2734.8.camel@offbook> (raw)
In-Reply-To: <20120502084711.GA24055@x2.net.home>
On Wed, 2012-05-02 at 10:47 +0200, Karel Zak wrote:
> On Sun, Apr 29, 2012 at 12:02:45AM +0200, Davidlohr Bueso wrote:
> > fdisk/Makefile.am | 2 +
> > fdisk/fdisk.c | 420 +------------------------------------------------
> > fdisk/fdisk.h | 64 ++++++++-
> > fdisk/fdiskdoslabel.c | 323 +++++++++++++++++++++++++++++++++++++
> > fdisk/fdiskdoslabel.h | 50 ++++++
> > 5 files changed, 446 insertions(+), 413 deletions(-)
> > create mode 100644 fdisk/fdiskdoslabel.c
> > create mode 100644 fdisk/fdiskdoslabel.h
>
> Applied, but I guess it's the first step only -- for example
> new_partition(), add_partition(), ... still contain DOS label code.
> It would be nice to completely move the code to fdiskdoslabel.c
> before we start to work on the new internal API.
Yes, absolutely. This patch was ugly enough that I didn't want to
complicate it any further :) I plan on getting rid of the rest of DOS
code in fdisk.c soon.
>
> Thanks!
>
> Karel
>
>
next prev parent reply other threads:[~2012-05-02 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 22:02 [PATCH] fdisk: isolate dos label logic Davidlohr Bueso
2012-05-02 8:47 ` Karel Zak
2012-05-02 8:56 ` Davidlohr Bueso [this message]
2012-05-02 12:17 ` Karel Zak
2012-05-02 12:29 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335949002.2734.8.camel@offbook \
--to=dave@gnu.org \
--cc=kzak@redhat.com \
--cc=petr.uzel@suse.cz \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.