From: Peter Zijlstra <peterz@infradead.org>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, kvm@vger.kernel.org,
avi@redhat.com, mtosatti@redhat.com,
yoshikawa.takuya@oss.ntt.co.jp
Subject: Re: [RFC] sched: make callers check lock contention for cond_resched_lock()
Date: Thu, 03 May 2012 10:35:27 +0200 [thread overview]
Message-ID: <1336034127.13683.197.camel@twins> (raw)
In-Reply-To: <20120503171244.2debdd80931ccf35f387c5fe@gmail.com>
On Thu, 2012-05-03 at 17:12 +0900, Takuya Yoshikawa wrote:
>
> Although we can do that using spin_is_contended() and cond_resched(),
> changing cond_resched_lock() to satisfy such a need is another option.
>
Yeah, not a pretty patch. Changing all cond_resched_lock() sites just to
change one and in such an ugly way too.
So what's the impact of making spin_needbreak() work for !PREEMPT?
next prev parent reply other threads:[~2012-05-03 8:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 8:12 [RFC] sched: make callers check lock contention for cond_resched_lock() Takuya Yoshikawa
2012-05-03 8:35 ` Peter Zijlstra [this message]
2012-05-03 12:22 ` Takuya Yoshikawa
2012-05-03 12:29 ` Peter Zijlstra
2012-05-03 12:47 ` Avi Kivity
2012-05-03 14:11 ` Takuya Yoshikawa
2012-05-03 14:27 ` Avi Kivity
2012-05-03 14:38 ` Avi Kivity
2012-05-03 13:00 ` Takuya Yoshikawa
2012-05-03 15:47 ` Peter Zijlstra
2012-05-10 22:03 ` Takuya Yoshikawa
2012-05-18 7:26 ` Ingo Molnar
2012-05-18 16:10 ` Takuya Yoshikawa
2012-05-04 2:43 ` Michael Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336034127.13683.197.camel@twins \
--to=peterz@infradead.org \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.