From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757976Ab2ECSyK (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 May 2012 14:54:10 -0400
Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:15058 "EHLO
	hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753243Ab2ECSyI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 May 2012 14:54:08 -0400
X-Authority-Analysis: v=2.0 cv=J5EoHXbS c=1 sm=0 a=ZycB6UtQUfgMyuk2+PxD7w==:17 a=XQbtiDEiEegA:10 a=YECtLpki0LgA:10 a=5SG0PmZfjMsA:10 a=Q9fys5e9bTEA:10 a=meVymXHHAAAA:8 a=_nkV0h_IJbvyrkjp6CoA:9 a=PUjeQqilurYA:10 a=jeBq3FmKZ4MA:10 a=ZycB6UtQUfgMyuk2+PxD7w==:117
X-Cloudmark-Score: 0
X-Originating-IP: 74.67.80.29
Message-ID: <1336071245.14207.104.camel@gandalf.stny.rr.com>
Subject: Re: [PATCH v6 1/3] trace: Make removal of ring buffer pages atomic
From: Steven Rostedt <rostedt@goodmis.org>
To: Vaibhav Nagarnaik <vnagarnaik@google.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>, Ingo Molnar <mingo@redhat.com>,
        Laurent Chavey <chavey@google.com>,
        Justin Teravest <teravest@google.com>,
        David Sharp <dhsharp@google.com>, linux-kernel@vger.kernel.org
Date: Thu, 03 May 2012 14:54:05 -0400
In-Reply-To: <CAL26m8J8=-yvtW+7F+XqTKgZs4NxiT3gSYJFC3RetjBwJvzL2g@mail.gmail.com>
References: <1328212844-11889-2-git-send-email-vnagarnaik@google.com>
	 <1335388704-26790-1-git-send-email-vnagarnaik@google.com>
	 <1336010118.14207.75.camel@gandalf.stny.rr.com>
	 <CAL26m8KgvuUGhK_T91fM2dNtFt4+KSOb5-C8yNiZ888BZW1PEg@mail.gmail.com>
	 <1336049840.14207.82.camel@gandalf.stny.rr.com>
	 <1336054375.14207.84.camel@gandalf.stny.rr.com>
	 <CAL26m8J8=-yvtW+7F+XqTKgZs4NxiT3gSYJFC3RetjBwJvzL2g@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-15"
X-Mailer: Evolution 3.2.2-1 
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2012-05-03 at 11:43 -0700, Vaibhav Nagarnaik wrote:
> On Thu, May 3, 2012 at 7:12 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > It's also giving me errors when I try to enable events or anything else
> > when tracing_on is disabled.
> 
> Yes, I had to add a check to see if resizing is safe. I re-used
> record_disabled in this patch for that purpose.
> 
> In the next patch for "atomic addition of pages" I added a new field
> resize_disabled to guard against unsafe resizing. So with that patch,
> you won't see this behavior. It also fixes the issue with trace-cmd
> where the ring buffer doesn't get expanded.

Would it be possible to put that resize_disabled into the first patch so
we don't have this bug popping up in a git bisect?

-- Steve