All of lore.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@gnu.org>
To: Petr Uzel <petr.uzel@suse.cz>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 1/5] fdisk: remove unused hsc2sector macro
Date: Sun, 06 May 2012 20:53:14 +0200	[thread overview]
Message-ID: <1336330394.2685.16.camel@offbook> (raw)
In-Reply-To: <20120506173408.GA14007@skipper.site>

On Sun, 2012-05-06 at 19:34 +0200, Petr Uzel wrote:
> On Sun, May 06, 2012 at 02:10:16PM +0200, Davidlohr Bueso wrote:
> > From: Davidlohr Bueso <dave@gnu.org>
> > 
> > Signed-off-by: Davidlohr Bueso <dave@gnu.org>
> > ---
> > fdisk/fdisk.c |    2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > diff --git a/fdisk/fdisk.c b/fdisk/fdisk.c
> > index dccaf27..3543745 100644
> > --- a/fdisk/fdisk.c
> > +++ b/fdisk/fdisk.c
> > @@ -68,8 +68,6 @@ int MBRbuffer_changed;
> > #define sector(s) ((s) & 0x3f)
> > #define cylinder(s, c) ((c) | (((s) & 0xc0) << 2))
> > 
> > -#define hsc2sector(h,s,c) (sector(s) - 1 + sectors * \
> > - ((h) + heads * cylinder(s,c)))
> > #define set_hsc(h,s,c,sector) { \
> > s = sector % sectors + 1; \
> > sector /= sectors; \
> 
> This patch seems to be malformed. Could you please check what's wrong?

Hmm perhaps my mail client did something stupid (or me :)

From: Davidlohr Bueso <dave@gnu.org>
Date: Sun, 6 May 2012 20:51:37 +0200
Subject: [PATCH] fdisk: remove unused hsc2sector-macor

Signed-off-by: Davidlohr Bueso <dave@gnu.org>
---
 fdisk/fdisk.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fdisk/fdisk.c b/fdisk/fdisk.c
index dccaf27..3543745 100644
--- a/fdisk/fdisk.c
+++ b/fdisk/fdisk.c
@@ -68,8 +68,6 @@ int MBRbuffer_changed;
 #define sector(s)	((s) & 0x3f)
 #define cylinder(s, c)	((c) | (((s) & 0xc0) << 2))
 
-#define hsc2sector(h,s,c) (sector(s) - 1 + sectors * \
-				((h) + heads * cylinder(s,c)))
 #define set_hsc(h,s,c,sector) { \
 				s = sector % sectors + 1;	\
 				sector /= sectors;	\
-- 
1.7.4.1




  reply	other threads:[~2012-05-06 18:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-06 12:10 [PATCH 1/5] fdisk: remove unused hsc2sector macro Davidlohr Bueso
2012-05-06 17:34 ` Petr Uzel
2012-05-06 18:53   ` Davidlohr Bueso [this message]
2012-05-10  9:46     ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336330394.2685.16.camel@offbook \
    --to=dave@gnu.org \
    --cc=petr.uzel@suse.cz \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.