From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: netfilter@vger.kernel.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, coreteam@netfilter.org,
netfilter-devel@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH 00/13] net: Add and use ether_addr_equal
Date: Thu, 10 May 2012 08:56:55 +0200 [thread overview]
Message-ID: <1336633015.4334.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1336632860.22495.6.camel@joe2Laptop> (sfid-20120510_085441_236331_94537C40)
On Wed, 2012-05-09 at 23:54 -0700, Joe Perches wrote:
> On Thu, 2012-05-10 at 08:48 +0200, Johannes Berg wrote:
> > On Wed, 2012-05-09 at 21:21 -0400, David Miller wrote:
> >
> > > That case you didn't convert in mac80211 is probably the
> > > bug Johannes was talking about which started this whole
> > > discussion.
> >
> > The bug case that started it all is in net/wireless/scan.c and Emmanuel
> > has since changed it back to memcmp(). Not sure if that's the one you
> > were referring to or not :-)
>
> That's the one that I left alone.
>
> Post patch:
> $ git grep -n -w compare_ether_addr net
> net/batman-adv/main.h:198: * note: can't use compare_ether_addr() as it requires aligned memory
> net/wireless/scan.c:381: return compare_ether_addr(a->bssid, b->bssid);
Ok, great, then that means the fix from Emmanuel won't conflict when it
gets in.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 00/13] net: Add and use ether_addr_equal
Date: Thu, 10 May 2012 08:56:55 +0200 [thread overview]
Message-ID: <1336633015.4334.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1336632860.22495.6.camel@joe2Laptop> (sfid-20120510_085441_236331_94537C40)
On Wed, 2012-05-09 at 23:54 -0700, Joe Perches wrote:
> On Thu, 2012-05-10 at 08:48 +0200, Johannes Berg wrote:
> > On Wed, 2012-05-09 at 21:21 -0400, David Miller wrote:
> >
> > > That case you didn't convert in mac80211 is probably the
> > > bug Johannes was talking about which started this whole
> > > discussion.
> >
> > The bug case that started it all is in net/wireless/scan.c and Emmanuel
> > has since changed it back to memcmp(). Not sure if that's the one you
> > were referring to or not :-)
>
> That's the one that I left alone.
>
> Post patch:
> $ git grep -n -w compare_ether_addr net
> net/batman-adv/main.h:198: * note: can't use compare_ether_addr() as it requires aligned memory
> net/wireless/scan.c:381: return compare_ether_addr(a->bssid, b->bssid);
Ok, great, then that means the fix from Emmanuel won't conflict when it
gets in.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Joe Perches <joe@perches.com>
Cc: netfilter@vger.kernel.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, coreteam@netfilter.org,
netfilter-devel@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 00/13] net: Add and use ether_addr_equal
Date: Thu, 10 May 2012 08:56:55 +0200 [thread overview]
Message-ID: <1336633015.4334.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1336632860.22495.6.camel@joe2Laptop> (sfid-20120510_085441_236331_94537C40)
On Wed, 2012-05-09 at 23:54 -0700, Joe Perches wrote:
> On Thu, 2012-05-10 at 08:48 +0200, Johannes Berg wrote:
> > On Wed, 2012-05-09 at 21:21 -0400, David Miller wrote:
> >
> > > That case you didn't convert in mac80211 is probably the
> > > bug Johannes was talking about which started this whole
> > > discussion.
> >
> > The bug case that started it all is in net/wireless/scan.c and Emmanuel
> > has since changed it back to memcmp(). Not sure if that's the one you
> > were referring to or not :-)
>
> That's the one that I left alone.
>
> Post patch:
> $ git grep -n -w compare_ether_addr net
> net/batman-adv/main.h:198: * note: can't use compare_ether_addr() as it requires aligned memory
> net/wireless/scan.c:381: return compare_ether_addr(a->bssid, b->bssid);
Ok, great, then that means the fix from Emmanuel won't conflict when it
gets in.
johannes
next prev parent reply other threads:[~2012-05-10 6:56 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 4:56 [Bridge] [PATCH 00/13] net: Add and use ether_addr_equal Joe Perches
2012-05-09 4:56 ` Joe Perches
2012-05-09 4:56 ` Joe Perches
2012-05-09 4:56 ` [PATCH 01/13] etherdevice.h: Add ether_addr_equal Joe Perches
2012-05-09 4:56 ` [PATCH 02/13] 802: Convert compare_ether_addr to ether_addr_equal Joe Perches
2012-05-09 4:56 ` [PATCH 03/13] 8021q: " Joe Perches
2012-05-09 4:56 ` [Bridge] [PATCH 04/13] bridge: netfilter: " Joe Perches
2012-05-09 4:56 ` Joe Perches
2012-05-09 4:56 ` Joe Perches
2012-05-09 15:07 ` [Bridge] " Stephen Hemminger
2012-05-09 15:07 ` Stephen Hemminger
2012-05-09 4:56 ` [Bridge] [PATCH 05/13] bridge: " Joe Perches
2012-05-09 4:56 ` Joe Perches
2012-05-09 4:56 ` Joe Perches
2012-05-09 4:56 ` [PATCH 06/13] atm: " Joe Perches
2012-05-09 4:56 ` [PATCH 07/13] bluetooth: " Joe Perches
2012-05-09 4:56 ` Joe Perches
2012-05-09 4:56 ` [PATCH 08/13] mac80211: " Joe Perches
2012-05-09 4:56 ` [PATCH 09/13] mac80211: Convert compare_ether_addr to ether_addr_equal by hand Joe Perches
2012-05-09 4:56 ` [PATCH 10/13] netfilter: Convert compare_ether_addr to ether_addr_equal Joe Perches
2012-05-09 4:56 ` [PATCH 11/13] wireless: " Joe Perches
2012-05-09 4:56 ` [PATCH 12/13] wireless: Convert compare_ether_addr to ether_addr_equal by hand Joe Perches
2012-05-09 4:56 ` [PATCH 13/13] dsa: Convert compare_ether_addr to ether_addr_equal Joe Perches
2012-05-10 1:21 ` [Bridge] [PATCH 00/13] net: Add and use ether_addr_equal David Miller
2012-05-10 1:21 ` David Miller
2012-05-10 1:21 ` David Miller
2012-05-10 1:48 ` [Bridge] " Joe Perches
2012-05-10 1:48 ` Joe Perches
2012-05-10 1:48 ` Joe Perches
2012-05-10 1:53 ` [Bridge] " David Miller
2012-05-10 1:53 ` David Miller
2012-05-10 1:53 ` David Miller
2012-05-10 6:48 ` [Bridge] " Johannes Berg
2012-05-10 6:48 ` Johannes Berg
2012-05-10 6:48 ` Johannes Berg
2012-05-10 6:54 ` [Bridge] " Joe Perches
2012-05-10 6:54 ` Joe Perches
2012-05-10 6:56 ` Johannes Berg [this message]
2012-05-10 6:56 ` Johannes Berg
2012-05-10 6:56 ` Johannes Berg
2012-05-10 7:08 ` [Bridge] " Emmanuel Grumbach
2012-05-10 7:08 ` Emmanuel Grumbach
2012-05-10 7:08 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336633015.4334.2.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.