From: Johannes Berg <johannes@sipsolutions.net>
To: Tobias Diedrich <ranma+openwrt@tdiedrich.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
OpenWrt Development List <openwrt-devel@lists.openwrt.org>,
linux-wireless@vger.kernel.org
Subject: Re: rt28xx AP-mode problem with commit 3edaf3e61fda3aa9ff8d38445bf92f2bec23bf63 "mac80211: manage AP netdev carrier state"
Date: Thu, 10 May 2012 10:13:00 +0200 [thread overview]
Message-ID: <1336637580.4334.10.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120509212859.GF5472@yumi.tdiedrich.de>
On Wed, 2012-05-09 at 23:28 +0200, Tobias Diedrich wrote:
> This seems to be the crucial hunk (and it conveniently ermoves a
> check against NL80211_IFTYPE_AP), if I revert just this it works for
> me:
>
> Index: compat-wireless-2012-04-17/net/mac80211/iface.c
> ===================================================================
> --- compat-wireless-2012-04-17.orig/net/mac80211/iface.c 2012-05-09 01:00:39.197975402 +0200
> +++ compat-wireless-2012-04-17/net/mac80211/iface.c 2012-05-09 01:02:32.514918371 +0200
> @@ -411,8 +407,7 @@
> ieee80211_bss_info_change_notify(sdata, changed);
>
> if (sdata->vif.type == NL80211_IFTYPE_STATION ||
> - sdata->vif.type == NL80211_IFTYPE_ADHOC ||
> - sdata->vif.type == NL80211_IFTYPE_AP)
> + sdata->vif.type == NL80211_IFTYPE_ADHOC)
> netif_carrier_off(dev);
Well ... yeah, if you remove this change all the other changes don't
really do anything so that's not really surprising :)
johannes
next prev parent reply other threads:[~2012-05-10 8:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 10:57 rt28xx AP-mode problem with commit 3edaf3e61fda3aa9ff8d38445bf92f2bec23bf63 "mac80211: manage AP netdev carrier state" Tobias Diedrich
2012-05-09 11:59 ` Johannes Berg
2012-05-09 12:18 ` Tobias Diedrich
2012-05-09 21:04 ` Tobias Diedrich
2012-05-09 21:28 ` Tobias Diedrich
2012-05-10 8:13 ` Johannes Berg [this message]
2012-05-10 8:15 ` Johannes Berg
2012-05-10 8:27 ` Johannes Berg
2012-05-18 0:57 ` Tobias Diedrich
2012-05-18 1:18 ` Tobias Diedrich
2012-05-18 17:16 ` Johannes Berg
2012-05-19 7:54 ` Tobias Diedrich
2012-05-11 23:39 ` Tobias Diedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336637580.4334.10.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=openwrt-devel@lists.openwrt.org \
--cc=ranma+openwrt@tdiedrich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.