From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Hein Tibosch <hein_tibosch@yahoo.es>
Cc: linux-omap <linux-omap@vger.kernel.org>
Subject: Re: omapfb-main.c: check result of simple_strtoul
Date: Thu, 10 May 2012 11:23:14 +0300 [thread overview]
Message-ID: <1336638194.5182.28.camel@deskari> (raw)
In-Reply-To: <4FAA838A.3040106@yahoo.es>
[-- Attachment #1: Type: text/plain, Size: 638 bytes --]
On Wed, 2012-05-09 at 22:47 +0800, Hein Tibosch wrote:
> Tomi,
>
>
> In drivers/video/omap2/omapfb/omapfb-main.c:
>
> static int omapfb_parse_vram_param(const char *param, int max_entries,
> unsigned long *sizes, unsigned long *paddrs)
> {
> int fbnum;
> unsigned long size;
> unsigned long paddr = 0;
> char *p, *start;
> start = (char *)param;
> while (1) {
> p = start;
> fbnum = simple_strtoul(p, &p, 10);
> - if (p == param)
> + if (p == start)
>
> correct?
Yes, looks like a correct fix. I'll cook up a patch.
How did you encounter the bug? What was the outcome?
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-10 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 14:47 omapfb-main.c: check result of simple_strtoul Hein Tibosch
2012-05-10 8:23 ` Tomi Valkeinen [this message]
2012-05-10 10:51 ` Hein Tibosch
2012-05-10 11:02 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336638194.5182.28.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=hein_tibosch@yahoo.es \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.