From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 2/2] drm/i915/dp: Remove eDP special cases from bandwidth checks Date: Thu, 10 May 2012 19:40:23 +0100 Message-ID: <1336675242_230176@CP5-2952> References: <1318610630-20459-1-git-send-email-ajax@redhat.com> <1318610630-20459-2-git-send-email-ajax@redhat.com> <1318872559.7630.56.camel@atropine> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EF169E732 for ; Thu, 10 May 2012 11:40:47 -0700 (PDT) In-Reply-To: <1318872559.7630.56.camel@atropine> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson , Keith Packard Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 17 Oct 2011 13:29:18 -0400, Adam Jackson wrote: > On Fri, 2011-10-14 at 23:13 -0700, Keith Packard wrote: > > On Fri, 14 Oct 2011 12:43:50 -0400, Adam Jackson wrote: > > > > > These were just working around the math being wrong. > > > > One wonders whether this might break some machines which are currently > > working. Should we emit an error or something if an eDP panel asks for > > the impossible? > > Probably, but I think in cases where that happens we should be > considering the driver to be broken before the panel. No one's going to > manufacture hardware that can't run Windows. Sigh, This patch did introduce a number of regressions, notably https://bugs.freedesktop.org/show_bug.cgi?id=45801 -Chris -- Chris Wilson, Intel Open Source Technology Centre