From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Introduce for_each_ring() macro Date: Fri, 11 May 2012 00:18:05 +0100 Message-ID: <1336691906_233174@CP5-2952> References: <1336602461-24423-1-git-send-email-chris@chris-wilson.co.uk> <1336684910-19881-1-git-send-email-chris@chris-wilson.co.uk> <20120510153932.00012f65@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 144699E768 for ; Thu, 10 May 2012 16:18:30 -0700 (PDT) In-Reply-To: <20120510153932.00012f65@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 10 May 2012 15:39:32 -0700, Ben Widawsky wrote: > I'm not opposed to this change, but it would have probably been better > to not remove the BUG_ONs. I actually removed them because in order to satisfy them we have to initialise rings we never use (and have another patch so that we only intialise rings once inside intel_ringbuffer.c). We were causing extra work for ourselves for no good reason. And we need to cull the BUG_ONs for which a WARN and recovery would serve better. -Chris -- Chris Wilson, Intel Open Source Technology Centre