From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Introduce for_each_ring() macro Date: Fri, 11 May 2012 10:26:11 +0100 Message-ID: <1336728393_239965@CP5-2952> References: <1336602461-24423-1-git-send-email-chris@chris-wilson.co.uk> <1336684910-19881-1-git-send-email-chris@chris-wilson.co.uk> <20120510153932.00012f65@bwidawsk.net> <20120511090012.GB5085@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id EAE0E9E79A for ; Fri, 11 May 2012 02:26:36 -0700 (PDT) In-Reply-To: <20120511090012.GB5085@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 11 May 2012 11:00:12 +0200, Daniel Vetter wrote: > On Thu, May 10, 2012 at 03:39:32PM -0700, Ben Widawsky wrote: > > Sneaky way to get rid of the warning you never liked... I won't forget > > this. > > I concur that killing that warnings is sneaky ;-) Can't we just keep them > - the ring->obj check should do the right thing? Or what exactly do I > miss? Other than I'm not a fan of those warnings; completely in the wrong spot. If you want a warning that i915_gpu_idle is not doing its job even in the face of a wedged GPU (so in fact i915_gem_reset failing), it would be better to place those warnings inside i915_gpu_idle. -Chris -- Chris Wilson, Intel Open Source Technology Centre