From: Johannes Berg <johannes@sipsolutions.net>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: [PATCH 1/4 v2] iwlwifi: fix prints in iwl_rx_handle
Date: Fri, 11 May 2012 12:59:02 +0200 [thread overview]
Message-ID: <1336733942.4310.21.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1336665952-24363-2-git-send-email-johannes@sipsolutions.net> (sfid-20120510_180602_348662_B04FB76A)
From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
The debug prints were wrong and buggy. The HW pointer wasn't printed
correctly, it was mixed up with the pointer to the rxbuf.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Wey-Yi W Guy <wey-yi.w.guy@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
v2: make patch apply -- looks like some whitespace diff to upstream
crept into our tree, thanks dileks.
--- a/drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c
@@ -499,7 +499,7 @@ static void iwl_rx_handle(struct iwl_trans *trans)
/* Rx interrupt, but nothing sent from uCode */
if (i == r)
- IWL_DEBUG_RX(trans, "r = %d, i = %d\n", r, i);
+ IWL_DEBUG_RX(trans, "HW = SW = %d\n", r);
/* calculate total frames need to be restock after handling RX */
total_empty = r - rxq->write_actual;
@@ -515,8 +515,8 @@ static void iwl_rx_handle(struct iwl_trans *trans)
rxb = rxq->queue[i];
rxq->queue[i] = NULL;
- IWL_DEBUG_RX(trans, "rxbuf: r = %d, i = %d (%p)\n", rxb);
-
+ IWL_DEBUG_RX(trans, "rxbuf: HW = %d, SW = %d (%p)\n",
+ r, i, rxb);
iwl_rx_handle_rxbuf(trans, rxb);
i = (i + 1) & RX_QUEUE_MASK;
next prev parent reply other threads:[~2012-05-11 10:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 16:05 [PATCH 0/4] iwlwifi fixes Johannes Berg
2012-05-10 16:05 ` [PATCH 1/4] iwlwifi: fix prints in iwl_rx_handle Johannes Berg
2012-05-10 16:38 ` [PATCH 1/4] iwlwifi: Add __printf argument checking to __iwl_dbg Joe Perches
2012-05-10 16:50 ` Johannes Berg
2012-05-10 16:56 ` Johannes Berg
2012-05-10 17:34 ` Joe Perches
2012-05-10 17:40 ` Johannes Berg
2012-05-10 18:01 ` Joe Perches
2012-05-11 10:59 ` Johannes Berg [this message]
2012-05-11 16:49 ` [PATCH 1/4 v2] iwlwifi: fix prints in iwl_rx_handle Sedat Dilek
2012-05-10 16:05 ` [PATCH 2/4] iwlwifi: fix the Transmit Frame Descriptor rings Johannes Berg
2012-05-11 12:50 ` [PATCH 2/4 v2] " Johannes Berg
2012-05-11 16:50 ` Sedat Dilek
2012-05-16 15:16 ` [PATCH 2/4] " Johannes Berg
2012-05-10 16:05 ` [PATCH 3/4] iwlwifi: fix debug print in iwl_sta_calc_ht_flags Johannes Berg
2012-05-11 16:52 ` Sedat Dilek
2012-05-10 16:05 ` [PATCH 4/4] iwlwifi: do not send lq cmd when station add fails Johannes Berg
2012-05-11 16:53 ` Sedat Dilek
2012-05-16 17:05 ` [PATCH 0/4] iwlwifi fixes John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336733942.4310.21.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.