From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 3/3] drm/i915: Replace the feature tests for BLT/BSD with ring init checks Date: Fri, 11 May 2012 21:24:06 +0100 Message-ID: <1336767866_248148@CP5-2952> References: <1336742972-12713-1-git-send-email-chris@chris-wilson.co.uk> <1336742972-12713-3-git-send-email-chris@chris-wilson.co.uk> <20120511125814.14d997b3@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id B12E4A0CA7 for ; Fri, 11 May 2012 13:24:33 -0700 (PDT) In-Reply-To: <20120511125814.14d997b3@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 11 May 2012 12:58:14 -0700, Ben Widawsky wrote: > On Fri, 11 May 2012 14:29:32 +0100 > Chris Wilson wrote: > > > When userspace asks whether the driver supports the BLT or BSD rings for > > this chip, simply report whether those particular rings are initialised > > > > This was the one place where I felt HAS_BLT and HAS_BSD was sort of > nice to keep around to distinguish HW has the ring vs. HW successfully > initialized the rings. The hw supporting those rings is useless if the driver doesn't, imo. -Chris -- Chris Wilson, Intel Open Source Technology Centre