From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Convert BUG_ON(!pll->active) and friends to a WARN Date: Sun, 13 May 2012 21:15:51 +0100 Message-ID: <1336940179_9886@CP5-2952> References: <1336899249-2612-1-git-send-email-chris@chris-wilson.co.uk> <1336936572-19548-1-git-send-email-chris@chris-wilson.co.uk> <20120513200810.GG4720@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 9094B9E76E for ; Sun, 13 May 2012 13:16:22 -0700 (PDT) In-Reply-To: <20120513200810.GG4720@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, 13 May 2012 22:08:10 +0200, Daniel Vetter wrote: > On Sun, May 13, 2012 at 08:16:12PM +0100, Chris Wilson wrote: > > Turn a fatal lockup into a merely blank display with lots of shouty > > messages. > > > > v2: Whilst in the area, convert the other BUG_ON into less fatal errors. > > In particular, note that we may be called on a PCH platform not using > > PLLs, such as Haswell, and so we do not always want to BUG_ON(!pll) > > > > Signed-off-by: Chris Wilson > > Ok, I guess you want me to drop v1 of this again. I'll wait for a bit of > feedback on these two then (and the tested-by from qa on the 2nd one). Up to you, I thought that the original patch was overshadowed by the your change request and little reason for it to be split. It would be good to get QA's tested-by on the second patch at any rate. -Chris -- Chris Wilson, Intel Open Source Technology Centre