From: Chris Wilson <chris@chris-wilson.co.uk>
To: Raphael Carvalho <rsc.utroz@gmail.com>,
keithp@keithp.com, airlied@linux.ie,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers/gpu/drm/i915: Fixed uninitialized variables (warnings).
Date: Tue, 15 May 2012 07:19:30 +0100 [thread overview]
Message-ID: <1337062773_35388@CP5-2952> (raw)
In-Reply-To: <CAC+pAyfw5UFnuLyrpN5D2r9J=PijtgrdwJUmMh3xthM3Rx-Zvw@mail.gmail.com>
On Mon, 14 May 2012 20:57:07 -0300, Raphael Carvalho <rsc.utroz@gmail.com> wrote:
> From 1e77059e8f3158fd4844e3f6a5466a063d2f407e Mon Sep 17 00:00:00 2001
> From: "Raphael S.Carvalho" <utroz@oakcoders.com>
> Date: Mon, 14 May 2012 20:19:24 -0300
> Subject: [PATCH 1/1] drivers/gpu/drm/i915: Fixed uninitialized
> variables (warnings).
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> As you see, this modifications were really very important because if the
> remain variable receives a value lower or equals than 0 from the args->size
> variable, indeed, a bad behavior could ocurrs.
Which is checked for before calling the function. Look harder at what
gcc is trying to tell you, the actual location of gcc's error is inside
an inlined function...
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
prev parent reply other threads:[~2012-05-15 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 23:57 [PATCH 1/1] drivers/gpu/drm/i915: Fixed uninitialized variables (warnings) Raphael Carvalho
2012-05-15 6:19 ` Chris Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337062773_35388@CP5-2952 \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rsc.utroz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.