All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: add __printf argument checking
Date: Wed, 16 May 2012 19:55:28 +0200	[thread overview]
Message-ID: <1337190928.18519.11.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20120516174121.GF3508@tuxdriver.com>

On Wed, 2012-05-16 at 13:41 -0400, John W. Linville wrote:
> This one causes a few warnings here -- can we fix those at the same time as we add this?
> 
>   CC      drivers/net/wireless/iwlwifi/iwl-agn-sta.o
> drivers/net/wireless/iwlwifi/iwl-agn-sta.c: In function ‘iwl_sta_calc_ht_flags’:
> drivers/net/wireless/iwlwifi/iwl-agn-sta.c:238:2: warning: too few arguments for format
> 
>   CC      drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.o
> drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c: In function ‘iwl_rx_handle’:
> drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c:516:3: warning: format ‘%d’ expects type ‘int’, but argument 6 has type ‘struct iwl_rx_mem_buffer *’
> drivers/net/wireless/iwlwifi/iwl-trans-pcie-rx.c:516:3: warning: too few arguments for format

I think they were gone by the time I did this, but you said you had to
skip a few patches (some of which fixed such bugs) as they didn't apply.

johannes


  reply	other threads:[~2012-05-16 17:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-15 13:01 [PATCH] iwlwifi: add __printf argument checking Johannes Berg
2012-05-16 17:41 ` John W. Linville
2012-05-16 17:55   ` Johannes Berg [this message]
2012-05-16 18:10     ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337190928.18519.11.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.