All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Colin Cross <ccross@android.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Hillf Danton <dhillf@gmail.com>
Subject: Re: [PATCH] sched/rt: fix SCHED_RR across cgroups
Date: Fri, 18 May 2012 10:56:35 +0200	[thread overview]
Message-ID: <1337331395.573.3.camel@twins> (raw)
In-Reply-To: <1337229266-15798-1-git-send-email-ccross@android.com>

On Wed, 2012-05-16 at 21:34 -0700, Colin Cross wrote:
> task_tick_rt has an optimization to only reschedule SCHED_RR tasks
> if they were the only element on their rq.  However, with cgroups
> a SCHED_RR task could be the only element on its per-cgroup rq but
> still be competing with other SCHED_RR tasks in its parent's
> cgroup.  In this case, the SCHED_RR task in the child cgroup would
> never yield at the end of its timeslice.  If the child cgroup
> rt_runtime_us was the same as the parent cgroup rt_runtime_us,
> the task in the parent cgroup would starve completely.
> 
> Modify task_tick_rt to check that the task is the only task on its
> rq, and that the each of the scheduling entities of its ancestors
> is also the only entity on its rq.
> 
> Signed-off-by: Colin Cross <ccross@android.com>

OK, fair enough.. one does wonder though, WTH is android doing with
SCHED_RR?

  reply	other threads:[~2012-05-18  8:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-17  4:34 [PATCH] sched/rt: fix SCHED_RR across cgroups Colin Cross
2012-05-18  8:56 ` Peter Zijlstra [this message]
2012-05-18 17:52   ` Colin Cross
2012-05-18 18:37     ` Peter Zijlstra
2012-05-19  0:13       ` Colin Cross
2012-05-19 13:11         ` Dario Faggioli
2012-05-19 20:37           ` Colin Cross
2012-05-23 13:32             ` Dario Faggioli
2012-05-25 11:52               ` Peter Zijlstra
2012-05-25 13:12                 ` Steven Rostedt
2012-05-25 17:55                   ` Paul E. McKenney
2012-05-30 13:40 ` [tip:sched/urgent] sched/rt: Fix " tip-bot for Colin Cross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337331395.573.3.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=ccross@android.com \
    --cc=dhillf@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.