From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] Revert "kmod: Use base_libdir for installing libkmod"
Date: Fri, 18 May 2012 11:29:11 +0100 [thread overview]
Message-ID: <1337336951.28145.0.camel@ted> (raw)
In-Reply-To: <73807C59-D904-44D4-89D6-50B9C268B911@dominion.thruhere.net>
On Fri, 2012-05-18 at 09:52 +0200, Koen Kooi wrote:
> Op 17 mei 2012, om 23:02 heeft Richard Purdie het vo
> Those QA checks are a joke. I can fix the QA warnings by moving all
> kmod binaries to $bindir or $sbindir since binaries in /usr/bin
> and /usr/bin are exempt from the checks. That would break the
> split /usr case as well. These checks are global as well when they
> only should apply to recipes needed to get /usr mounted.
>
> That's why I consider the current checks misguided and harmfull. As
> seen from the breakage it allows people to break pkgconfig, which
> didn't get picked up by QA checks. And then it turns out that you an
> fix the QA warnings in such a way that it breaks the intent of the
> warnings.
So we need to improve the QA checks, no argument here.
> But this is all a false dillemma, you could have merged Otavio's patch
> (which I Ack'ed) which supports split /usr and puts the pkgconfig in
> the right place.
I likely still will but I was worried when he replied saying it still needed more
testing. I took your reply to the consolidated pull request to refer to
your patch.
Cheers,
Richard
next prev parent reply other threads:[~2012-05-18 10:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 9:32 [PATCH] Revert "kmod: Use base_libdir for installing libkmod" Koen Kooi
2012-05-15 20:54 ` Khem Raj
2012-05-17 20:29 ` Richard Purdie
2012-05-17 20:44 ` Koen Kooi
2012-05-17 21:02 ` Richard Purdie
2012-05-17 21:16 ` Tom Rini
2012-05-17 21:25 ` Paul Eggleton
2012-05-17 21:51 ` Otavio Salvador
2012-05-17 22:01 ` Paul Eggleton
2012-05-17 22:11 ` Otavio Salvador
2012-05-17 22:21 ` Paul Eggleton
2012-05-17 22:22 ` Phil Blundell
2012-05-17 22:50 ` Khem Raj
2012-05-17 23:00 ` Andreas Müller
2012-05-18 6:19 ` Koen Kooi
2012-05-18 8:16 ` Koen Kooi
2012-05-18 7:52 ` Koen Kooi
2012-05-18 10:29 ` Richard Purdie [this message]
2012-05-18 10:37 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337336951.28145.0.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=koen@dominion.thruhere.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.