From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
rdunlap@xenotime.net, akpm@linux-foundation.org,
khlebnikov@openvz.org, tglx@linutronix.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched: Set TAINT_UNSAFE_SMP after sleep-in-atomic bug
Date: Fri, 18 May 2012 13:02:54 +0200 [thread overview]
Message-ID: <1337338974.573.27.camel@twins> (raw)
In-Reply-To: <tip-1d76f4381601a259323ad4faadce18db08ddebcd@git.kernel.org>
On Fri, 2012-05-18 at 03:48 -0700, tip-bot for Konstantin Khlebnikov
wrote:
> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
This is the patch I objected to..
> +++ b/kernel/sched/core.c
> @@ -3138,6 +3138,7 @@ static noinline void __schedule_bug(struct task_struct *prev)
> if (irqs_disabled())
> print_irqtrace_events(prev);
> dump_stack();
> + add_taint(TAINT_UNSAFE_SMP);
> }
This should very much be TAINT_WARN.. it has nothing what so ever to do
with SMP.
next prev parent reply other threads:[~2012-05-18 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 23:22 + sched-set-taint_unsafe_smp-after-sleep-in-atomic-bug.patch added to -mm tree akpm
2012-05-18 10:48 ` [tip:sched/core] sched: Set TAINT_UNSAFE_SMP after sleep-in-atomic bug tip-bot for Konstantin Khlebnikov
2012-05-18 11:02 ` Peter Zijlstra [this message]
2012-05-18 12:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337338974.573.27.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rdunlap@xenotime.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.