From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joel Reardon <joel@clambassador.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] UBIFS: read crypto_lookup from datanodes to znodes
Date: Fri, 18 May 2012 16:23:23 +0300 [thread overview]
Message-ID: <1337347403.2483.48.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205161451250.27131@eristoteles.iwoars.net>
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On Wed, 2012-05-16 at 14:52 +0200, Joel Reardon wrote:
> + if (key_type(c, &(zbr->key)) == UBIFS_DATA_KEY) {
> + struct ubifs_data_node *dn = node;
> + long long crypto_lookup = le64_to_cpu(dn->crypto_lookup);
> + if (zbr->crypto_lookup != 0)
> + ubifs_assert(zbr->crypto_lookup == crypto_lookup);
> + else
> + zbr->crypto_lookup = crypto_lookup;
> + }
Could you please just inject this code directly to
'ubifs_tnc_read_node()' ? I think it is much easier and more nicer, no?
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-18 13:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 9:01 [PATCH] UBIFS: read crypto_lookup from datanodes to znodes Joel Reardon
2012-05-15 13:03 ` Artem Bityutskiy
2012-05-16 12:52 ` [PATCH v2] " Joel Reardon
2012-05-18 13:23 ` Artem Bityutskiy [this message]
2012-05-19 8:30 ` [PATCH v3] " Joel Reardon
2012-05-19 11:00 ` Artem Bityutskiy
2012-05-19 11:34 ` Artem Bityutskiy
2012-05-20 11:35 ` [patch] UBIFS: improved comment for data node's format history Joel Reardon
2012-05-20 18:34 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337347403.2483.48.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=joel@clambassador.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.