Re: [PATCH 0/4] Replace HobNotebook with gtk.Notebook, comments invited

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sat, 2012-04-14 at 11:23 +0100, Richard Purdie wrote:
> On Fri, 2012-04-13 at 16:24 -0700, Joshua Lock wrote:
> > *** This series prevents users of distros with old Gtk+ releases using Hob ***
> > 
> > This is a follow-on from my RFC of yesterday with a similar title. Sadly I 
> > hadn't realised that one of the API calls I am using is not available in the
> > version of gtk+ shipped with CentOS 6 (gtk.Notebook.set_action_widget).
> > 
> > This change will prevent CentOS 6 users from being able to use Hob.
> > 
> > I spent some time in Gtk+ internals trying to figure out if we can emulate the
> > behaviour on older versions but the GtkNotebook widget internals were enhanced
> > significantly to support the set_action_widget API.
> > 
> > I've submitted the change as an RFC regardless, it's ready to merge if we're
> > willing to make the sacrifice.
> > 
> > The primary motivation for making this change, and making it so late in the
> > cycle, is maintainability. The diffstat says it all - we're replacing an ~400LOC
> > custom widget with a ~100LOC set of 3 widgets which subclass standard toolkit
> > widgets.
> > 
> > An added benefit is that standard toolkit widgets generally integrate better
> > into the users OS thanks to inheriting their standard theme.
> > 
> > Tested on: 
> > Fedora 16 (x86_64) - PASS
> > CentOS 6.2 (x86_64) - FAIL: Gtk+ version too old
> > Ubuntu 10.04 (x86_64) - Fail: pygtk version too old
> > Ubuntu 12.04 Beta (x86_64) - PASS
> > 
> > Per the final patch in the series the changes here require gtk+-2.20 or newer
> > and pygtk 2.22 or newer.
> 
> Since we don't have a good external-python tarball solution in place
> yet, I'm going to have to hold off these patches until after the current
> release.

I've not gone ahead and merged these since they still seem to apply and
basically worked when I tested them just now.

Cheers,

Richard