From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: be more careful when returning
	-ENXIO in gmbus transfer
Date: Mon, 21 May 2012 19:24:34 +0100
Message-ID: <1337624682_164153@CP5-2952>
References: <20120520181553.GE5145@phenom.ffwll.local>
	<1337624388-32498-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 90BA69E78A
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 21 May 2012 11:24:50 -0700 (PDT)
In-Reply-To: <1337624388-32498-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Daniel Kurtz <djkurtz@chromium.org>
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 21 May 2012 20:19:48 +0200, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> ... flaky ddc hardware can cause a spurious NAK, resulting in the i2c
> core and drm edid functions not trying to retry the edid transfer.
> 
> Luckily the gmbus quiescenting also times out for these cases, so we
> can get out of this mess by returning -ETIMEDOUT for this specific
> case. This way we keep the fast-fail of returning -ENXIO if there is
> no device present, speeding up the boot process.
> 
> This regression has been introduced in
> 
> commit e646d5773572bf52017983d758bdf05777dc5600
> Author: Daniel Kurtz <djkurtz@chromium.org>
> Date:   Fri Mar 30 19:46:38 2012 +0800
> 
>     drm/i915/intel_i2c: always wait for IDLE before clearing NAK
> 
> v2: Return -ETIMEDOUT for this case and keep the -ENXIO for real NAKs,
> suggested by Daniel Kurtz.
> 
> Cc: Daniel Kurtz <djkurtz@chromium.org>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49518
> Reported-and-Tested-by: Julian Simioni <julian.simioni@gmail.com>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre