From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH] drm/i915: consolidate interrupt naming
	scheme
Date: Mon, 21 May 2012 22:45:11 +0100
Message-ID: <1337636720_167162@CP5-2952>
References: <1337356929-27188-1-git-send-email-ben@bwidawsk.net>
	<1337589967_155276@CP5-2952> <20120521140152.49a91dd4@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 246B09F5BC
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 21 May 2012 14:45:24 -0700 (PDT)
In-Reply-To: <20120521140152.49a91dd4@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, 21 May 2012 14:01:52 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> On Mon, 21 May 2012 09:46:00 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
> 
> > On Fri, 18 May 2012 09:02:09 -0700, Ben Widawsky <ben@bwidawsk.net> wrote:
> > > here are some opportunities to do things a bit better with the naming of
> > > things now that our hindsight is better.
> > 
> > The major problem with this is that it breaks the expectations of the
> > INTEL_ namespace, masquerading per-gen values as fixed constants for all
> > chipsets.
> > -Chris
> > 
> 
> With only a couple of exceptions (BSD user interrupt) there is no need
> for per-gen values. I think we shouldn't have much trouble maintaining
> this as is. The existing naming scheme wrongly calls things GEN6 when
> they were introduced earlier (I'm also not sure GT_ is valid for every
> interrupt). So the goal was to have I915_* for old stuff, INTEL_* for
> everything, and DEVICENAME_ for special cases.

I concur that the current names are rather ad-hoc and not well thought
out. I'm just not buying that this replacement is any better. INTEL_BSD
is a complete turn off.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre