Re: [PATCH] Trivial sched: Pass domain_attr to build_sched_domains()

[Peter Zijlstra <peterz@infradead.org>]

On Wed, 2012-05-23 at 12:11 +0530, Kamalesh Babulal wrote:
> sched: Pass domain_attr to build_sched_domains()
> 
> build_sched_domains() is called from init_sched_domains()
> by explicitly passing NULL as second argument, which is
> of type sched_domain_attr. This patch calls build_sched_domains()
> with dattr_cur instead of NULL, as dattr_cur is also NULL.

So what's the point? Rather clean up the dattr crap, no?

> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 22a19ae..32ccf13 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6735,7 +6735,7 @@ static int init_sched_domains(const struct cpumask *cpu_map)
>  		doms_cur = &fallback_doms;
>  	cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);
>  	dattr_cur = NULL;
> -	err = build_sched_domains(doms_cur[0], NULL);
> +	err = build_sched_domains(doms_cur[0], dattr_cur);
>  	register_sched_domain_sysctl();
> 
>  	return err;
>