Re: [PATCH 3 of 3] libxl: make it possible to explicitly specify default sched params

[Dario Faggioli <raistlin@linux.it>]

[-- Attachment #1.1: Type: text/plain, Size: 3059 bytes --]

On Wed, 2012-05-23 at 10:26 +0100, Ian Campbell wrote:
> # HG changeset patch
> # User Ian Campbell <ian.campbell@citrix.com>
> # Date 1337764865 -3600
> # Node ID b6221bcdf9a9045b49a2ddd7877602788f657bad
> # Parent  7d8428388b775a0b26cf88f89ec8f99f5fc8ce25
> libxl: make it possible to explicitly specify default sched params
> 
> To do so we define a descriminating value which is never a valid real value for
> each parameter.
> 
> While there:
> 
>  - removed libxl_sched_*_domain in favour of libxl_sched_params.
>  - use this new functionality for the various xl commands which set sched
>    parameters, which saves an explicit read-modify-write in xl.
>  - removed call of xc_domain_getinfolist from a few functions which weren't
>    actually using the result (looks like a cut and paste error)
>  - fix xl which was setting period for a variety of different config keys.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
Might be my fault, but I can't get this patch to build:

xl_cmdimpl.c:4365:47: error: unknown type name ‘libxl_sched_credit_domain’
xl_cmdimpl.c: In function ‘sched_credit_domain_output’:
xl_cmdimpl.c:4401:5: error: unknown type name ‘libxl_sched_credit_domain’
xl_cmdimpl.c:4408:5: error: implicit declaration of function ‘sched_credit_domain_get’ [-Werror=implicit-function-declaration]
xl_cmdimpl.c:4415:15: error: request for member ‘weight’ in something not a structure or union
xl_cmdimpl.c:4416:15: error: request for member ‘cap’ in something not a structure or union
xl_cmdimpl.c:4418:5: error: implicit declaration of function ‘libxl_sched_credit_domain_dispose’ [-Werror=implicit-function-declaration]
xl_cmdimpl.c: At top level:
xl_cmdimpl.c:4444:16: error: unknown type name ‘libxl_sched_credit2_domain’
xl_cmdimpl.c:4456:16: error: unknown type name ‘libxl_sched_credit2_domain’
xl_cmdimpl.c: In function ‘sched_credit2_domain_output’:
xl_cmdimpl.c:4471:5: error: unknown type name ‘libxl_sched_credit2_domain’
xl_cmdimpl.c:4478:5: error: implicit declaration of function ‘sched_credit2_domain_get’ [-Werror=implicit-function-declaration]
xl_cmdimpl.c:4485:15: error: request for member ‘weight’ in something not a structure or union
xl_cmdimpl.c:4487:5: error: implicit declaration of function ‘libxl_sched_credit2_domain_dispose’ [-Werror=implicit-function-declaration]
xl_cmdimpl.c: At top level:
xl_cmdimpl.c:4492:16: error: unknown type name ‘libxl_sched_sedf_domain’
xl_cmdimpl.c:4504:16: error: unknown type name ‘libxl_sched_sedf_domain’
...
...

It seems like there are some leftovers of the old
libxl_sched_{credit,...}_domain in xl_cmdimpl.c ... Perhaps a missing
add/refresh on our side?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel