From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH 01/11] drm/i915: add set_infoframes to
	struct intel_hdmi
Date: Fri, 25 May 2012 00:02:53 +0100
Message-ID: <1337900588_233371@CP5-2952>
References: <1337892594-31908-1-git-send-email-przanoni@gmail.com>
	<1337892594-31908-2-git-send-email-przanoni@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236])
	by gabe.freedesktop.org (Postfix) with ESMTP id 02BF69EB1B
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 24 May 2012 16:03:18 -0700 (PDT)
In-Reply-To: <1337892594-31908-2-git-send-email-przanoni@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>, intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 24 May 2012 17:49:43 -0300, Paulo Zanoni <przanoni@gmail.com> wrote:
> +void g4x_set_infoframes(struct drm_encoder *encoder,
> +			struct drm_display_mode *adjusted_mode)

This and all that follow should be static. Adding a non-intel function
to our module's namespace is indicative of a gross hack, or as in this
case, a mistake.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre