All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] lib/bb/fetch2: fix comments for verify_checksum
@ 2012-05-24 15:47 Paul Eggleton
  2012-05-25 10:11 ` Richard Purdie
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggleton @ 2012-05-24 15:47 UTC (permalink / raw)
  To: bitbake-devel

This function no longer returns a value, it raises errors instead, so
update the comments to reflect this.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 bitbake/lib/bb/fetch2/__init__.py |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
index d4b6c3e..6ae69cd 100644
--- a/bitbake/lib/bb/fetch2/__init__.py
+++ b/bitbake/lib/bb/fetch2/__init__.py
@@ -274,13 +274,10 @@ def verify_checksum(u, ud, d):
     """
     verify the MD5 and SHA256 checksum for downloaded src
 
-    return value:
-        - True: a checksum matched
-        - False: neither checksum matched
+    Raises a FetchError if one or both of the SRC_URI checksums do not match
+    the downloaded file, or if BB_STRICT_CHECKSUM is set and there are no
+    checksums specified.
 
-    if checksum is missing in recipes file, "BB_STRICT_CHECKSUM" decide the return value.
-    if BB_STRICT_CHECKSUM = "1" then return false as unmatched, otherwise return true as
-    matched
     """
 
     if not ud.method.supports_checksum(ud):
-- 
1.7.9.5




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] lib/bb/fetch2: fix comments for verify_checksum
  2012-05-24 15:47 [PATCH] lib/bb/fetch2: fix comments for verify_checksum Paul Eggleton
@ 2012-05-25 10:11 ` Richard Purdie
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2012-05-25 10:11 UTC (permalink / raw)
  To: Paul Eggleton; +Cc: bitbake-devel

On Thu, 2012-05-24 at 16:47 +0100, Paul Eggleton wrote:
> This function no longer returns a value, it raises errors instead, so
> update the comments to reflect this.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>  bitbake/lib/bb/fetch2/__init__.py |    9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

Merged to master, thanks.

Richard




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-25 10:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-24 15:47 [PATCH] lib/bb/fetch2: fix comments for verify_checksum Paul Eggleton
2012-05-25 10:11 ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.