From: Fabio Estevam <festevam@gmail.com>
To: kernel@pengutronix.de
Cc: shawn.guo@freescale.com,
Fabio Estevam <fabio.estevam@freescale.com>,
Herbert Xu <herbert@gondor.hengli.com.au>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 03/15] hw_random: mxc-rnga: Use clk_prepare_enable/clk_disable_unprepare
Date: Sat, 26 May 2012 13:03:52 -0300 [thread overview]
Message-ID: <1338048232-3523-1-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1337987696-31728-4-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@freescale.com>
Prepare the clock before enabling it.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <linux-kernel@vger.kernel.org>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Add missing clk_disable_unprepare(clk) in the remove path
drivers/char/hw_random/mxc-rnga.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/hw_random/mxc-rnga.c b/drivers/char/hw_random/mxc-rnga.c
index 187c6be..430582c 100644
--- a/drivers/char/hw_random/mxc-rnga.c
+++ b/drivers/char/hw_random/mxc-rnga.c
@@ -154,7 +154,7 @@ static int __init mxc_rnga_probe(struct platform_device *pdev)
goto out;
}
- clk_enable(clk);
+ clk_prepare_enable(clk);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
@@ -196,7 +196,7 @@ err_ioremap:
release_mem_region(res->start, resource_size(res));
err_region:
- clk_disable(clk);
+ clk_disable_unprepare(clk);
clk_put(clk);
out:
@@ -215,7 +215,7 @@ static int __exit mxc_rnga_remove(struct platform_device *pdev)
release_mem_region(res->start, resource_size(res));
- clk_disable(clk);
+ clk_disable_unprepare(clk);
clk_put(clk);
return 0;
--
1.7.1
next prev parent reply other threads:[~2012-05-26 16:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 23:14 [PATCH 01/15] ARM: mx5: Use clk_prepare_enable/clk_disable_unprepare Fabio Estevam
2012-05-25 23:14 ` [PATCH 02/15] ata: " Fabio Estevam
2012-05-29 9:17 ` Sascha Hauer
2012-06-06 3:40 ` Fabio Estevam
2012-06-08 15:49 ` Jeff Garzik
2012-05-25 23:14 ` [PATCH 03/15] hw_random: mxc-rnga: " Fabio Estevam
2012-05-26 11:29 ` Sascha Hauer
2012-05-25 23:14 ` [PATCH 04/15] dma: imx-sdma: " Fabio Estevam
2012-05-26 11:30 ` Sascha Hauer
2012-05-26 16:03 ` Fabio Estevam [this message]
2012-05-29 9:17 ` [PATCH v2 03/15] hw_random: mxc-rnga: " Sascha Hauer
2012-06-06 3:41 ` Fabio Estevam
2012-06-06 5:24 ` Herbert Xu
2012-05-25 23:14 ` [PATCH 05/15] keyboard: imx_keypad: " Fabio Estevam
2012-05-29 9:18 ` Sascha Hauer
2012-06-06 3:41 ` Fabio Estevam
2012-05-25 23:14 ` [PATCH 06/15] video: mx1_camera: " Fabio Estevam
2012-05-29 9:20 ` Sascha Hauer
2012-06-06 3:43 ` Fabio Estevam
2012-06-06 16:04 ` Guennadi Liakhovetski
2012-06-06 16:37 ` Fabio Estevam
2012-05-25 23:14 ` [PATCH 07/15] video: mx2_camera: " Fabio Estevam
2012-05-29 9:21 ` Sascha Hauer
2012-05-25 23:14 ` [PATCH 08/15] video: mx2_emmaprp: " Fabio Estevam
2012-05-29 9:21 ` Sascha Hauer
2012-05-25 23:14 ` [PATCH 09/15] nand: mxc_nand: " Fabio Estevam
2012-05-27 12:36 ` Artem Bityutskiy
2012-05-25 23:14 ` [PATCH 11/15] serial: mxs-auart: " Fabio Estevam
2012-06-11 2:36 ` Shawn Guo
2012-05-25 23:14 ` [PATCH 15/15] ASoC: mxs-saif: " Fabio Estevam
2012-05-28 14:51 ` Mark Brown
2012-05-28 15:21 ` Fabio Estevam
2012-05-28 15:24 ` Mark Brown
2012-05-26 11:28 ` [PATCH 01/15] ARM: mx5: " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338048232-3523-1-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=herbert@gondor.hengli.com.au \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.