All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
To: maximilian attems <max-U9r9yeDMy7A@public.gmane.org>
Cc: linux-scsi <linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Dave Jones <davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Jeff Mahoney <jeffm-l3A5Bk7waGM@public.gmane.org>,
	Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>,
	initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Remove scsi_wait_scan module
Date: Mon, 28 May 2012 16:07:46 +0400	[thread overview]
Message-ID: <1338206866.6330.22.camel@dabdike> (raw)
In-Reply-To: <20120528100015.GB10036-VJknIhvjf2Ov8OlOgJ4AIV6hYfS7NtTn@public.gmane.org>

On Mon, 2012-05-28 at 10:00 +0000, maximilian attems wrote:
> On Sun, May 27, 2012 at 10:13:46AM +0100, James Bottomley wrote:
> > scsi_wait_scan was introduced with asynchronous host scanning as a hack
> > for distributions that weren't using proper udev based wait for root to
> > appear in their initramfs scripts.  In 2.6.30 Commit 
>  
> > c751085943362143f84346d274e0011419c84202
> > Author: Rafael J. Wysocki <rjw-KKrjLPT3xs0@public.gmane.org>
> > Date:   Sun Apr 12 20:06:56 2009 +0200
> > 
> >     PM/Hibernate: Wait for SCSI devices scan to complete during resume
> > 
> > Actually broke scsi_wait_scan because it renders
> > scsi_complete_async_scans() a nop for modular SCSI if you include
> > scsi_scans.h (which this module does).
> > 
> > The lack of bug reports is sufficient proof that this module is no
> > longer used.
> 
> We do use it in initramfs-tools.
> 
> There is quite a number of bug reports moaning about having to boot with
> `scsi_mod.scan=sync'. I didn't pass them on, because I didn't knew that
> the module itself got broken, for example:
> http://bugs.debian.org/616689

OK, so what these bugs show is the breakage ... basically scsi_wait_scan
isn't really waiting for the scans to complete.  I can fix it in stable
so you can close your bug reports, but if I do, can you also transition
away from using it so I can remove it in 3.5?

James



  parent reply	other threads:[~2012-05-28 12:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-27  9:13 Remove scsi_wait_scan module James Bottomley
2012-05-27 14:48 ` Jeff Mahoney
     [not found] ` <1338110026.2957.5.camel-sFMDBYUN5F8GjUHQrlYNx2Wm91YjaHnnhRte9Li2A+AAvxtiuMwx3w@public.gmane.org>
2012-05-28 10:00   ` maximilian attems
     [not found]     ` <20120528100015.GB10036-VJknIhvjf2Ov8OlOgJ4AIV6hYfS7NtTn@public.gmane.org>
2012-05-28 12:07       ` James Bottomley [this message]
2012-05-30 10:03         ` maximilian attems
2012-05-30 18:26         ` Dan Williams
     [not found]           ` <CAA9_cmfh9ZtepX+hjLVRM95u_pAe90kZTkBeVmFPWm8AMaqJ5g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-30 23:32             ` James Bottomley
2012-05-31  2:34               ` Dan Williams
     [not found]                 ` <CAA9_cmfZFm5+9ARB7tNVwNzwxJh3bPD=h7gMWhByjy00-qZvgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-31  8:15                   ` Harald Hoyer
     [not found]                     ` <4FC7288C.302-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-31 16:45                       ` Dan Williams
2012-05-31 17:44                         ` James Bottomley
2012-05-31 17:54                     ` Dave Jones
2012-05-31  8:21                 ` James Bottomley
     [not found]                   ` <1338452505.3073.4.camel-sFMDBYUN5F8GjUHQrlYNx2Wm91YjaHnnhRte9Li2A+AAvxtiuMwx3w@public.gmane.org>
2012-05-31 16:40                     ` Dan Williams
     [not found]                       ` <CAA9_cmet6tMi6rNNv_ktRwHh3_N4rOSd+_jBW0P_gomHLpOytw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-31 17:42                         ` James Bottomley
2012-05-31 18:49                           ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338206866.6330.22.camel@dabdike \
    --to=james.bottomley-d9phhud1jfjcxq6kfmz53/egyhegw8jk@public.gmane.org \
    --cc=ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org \
    --cc=davej-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jeffm-l3A5Bk7waGM@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=max-U9r9yeDMy7A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.