From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/3] drm/i915: clarify IBX dp workaround Date: Wed, 30 May 2012 11:28:13 +0100 Message-ID: <1338373725_354455@CP5-2952> References: <1338373918-1532-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 6B582A0261 for ; Wed, 30 May 2012 03:28:50 -0700 (PDT) In-Reply-To: <1338373918-1532-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Intel Graphics Development Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org On Wed, 30 May 2012 12:31:56 +0200, Daniel Vetter wrote: > Instead of checking for !CPT, check for IBX to make it clearer that > this is a IBX-specific workaround. No functional change because we > smash the PPT PCH into the HAS_PCH_CPT check and atm DP isn't enabled > on the haswell LPT PCH yet. > > See Bspec Vol 3, Part 3, Section 4.[3-5].1 about DP[BCD], bit 30 for > details of this workaround. > > Signed-Off-by: Daniel Vetter Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre