From: Joe Perches <joe@perches.com>
To: balbi@ti.com
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] usb: gadget: pch_udc: Fix likely misuse of | for &
Date: Thu, 31 May 2012 12:44:43 -0700 [thread overview]
Message-ID: <1338493483.7229.2.camel@joe2Laptop> (raw)
In-Reply-To: <20120531072541.GC5377@arwen.pp.htv.fi>
On Thu, 2012-05-31 at 10:25 +0300, Felipe Balbi wrote:
> On Wed, May 30, 2012 at 01:25:57PM -0700, Joe Perches wrote:
> > Using | with a constant is always true.
> > Likely this should have be &.
> > Signed-off-by: Joe Perches <joe@perches.com>
> this looks good to me. Do you want me to carry it on my tree ?
> If you want to carry it out as a fix:
> Acked-by: Felipe Balbi <balbi@ti.com>
I presume that question is for Greg.
next prev parent reply other threads:[~2012-05-31 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-30 20:25 [PATCH 0/4] treewide: Fix likely misuses of | for & Joe Perches
2012-05-30 20:25 ` [PATCH 1/4] mac80211: Fix likely misuse " Joe Perches
2012-05-30 20:29 ` Ben Greear
2012-05-30 20:25 ` [PATCH 2/4] can: cc770: " Joe Perches
2012-05-31 20:54 ` Marc Kleine-Budde
2012-05-30 20:25 ` [PATCH 3/4] brcmfmac: " Joe Perches
2012-05-30 20:50 ` Arend van Spriel
2012-05-30 20:25 ` [PATCH 4/4] usb: gadget: pch_udc: " Joe Perches
2012-05-31 7:25 ` Felipe Balbi
2012-05-31 19:44 ` Joe Perches [this message]
2012-06-01 9:50 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338493483.7229.2.camel@joe2Laptop \
--to=joe@perches.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.