From: Fabio Estevam <festevam@gmail.com>
To: broonie@opensource.wolfsonmicro.com
Cc: gregkh@linuxfoundation.org, marc@cpdesign.com.au,
philippe.retornaz@epfl.ch, linux-kernel@vger.kernel.org,
joe@perches.com, Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH v2] regmap: Fix the size calculation for map->format.buf_size
Date: Thu, 31 May 2012 22:07:35 -0300 [thread overview]
Message-ID: <1338512855-26015-1-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1338509430-24416-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@freescale.com>
The word to be transmitted/received via regmap is composed by the following
parts:
config->reg_bits
config->val_bits
config->pad_bits
,so the total size should be calculated by summing up the number of bits of
each element and using a DIV_ROUND_UP to return the number of bytes.
While at it also use BITS_PER_BYTE annotation.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Use BITS_PER_BYTE annotation
drivers/base/regmap/regmap.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 2aa076e..9d6b2f8 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -246,12 +246,12 @@ struct regmap *regmap_init(struct device *dev,
map->lock = regmap_lock_mutex;
map->unlock = regmap_unlock_mutex;
}
- map->format.buf_size = (config->reg_bits + config->val_bits) / 8;
- map->format.reg_bytes = DIV_ROUND_UP(config->reg_bits, 8);
- map->format.pad_bytes = config->pad_bits / 8;
- map->format.val_bytes = DIV_ROUND_UP(config->val_bits, 8);
- map->format.buf_size += map->format.pad_bytes;
- map->reg_shift = config->pad_bits % 8;
+ map->format.reg_bytes = DIV_ROUND_UP(config->reg_bits, BITS_PER_BYTE);
+ map->format.pad_bytes = config->pad_bits / BITS_PER_BYTE;
+ map->format.val_bytes = DIV_ROUND_UP(config->val_bits, BITS_PER_BYTE);
+ map->format.buf_size = DIV_ROUND_UP(config->reg_bits +
+ config->val_bits + config->pad_bits, BITS_PER_BYTE);
+ map->reg_shift = config->pad_bits % BITS_PER_BYTE;
if (config->reg_stride)
map->reg_stride = config->reg_stride;
else
--
1.7.1
next prev parent reply other threads:[~2012-06-01 1:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 0:10 [PATCH] regmap: Fix the size calculation for map->format.buf_size Fabio Estevam
2012-06-01 0:17 ` Joe Perches
2012-06-01 1:07 ` Fabio Estevam [this message]
2012-06-03 12:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338512855-26015-1-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc@cpdesign.com.au \
--cc=philippe.retornaz@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.