From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/3] drm/i915: clarify IBX dp workaround Date: Fri, 01 Jun 2012 21:04:48 +0100 Message-ID: <1338581125_413454@CP5-2952> References: <1338373918-1532-1-git-send-email-daniel.vetter@ffwll.ch> <1338373725_354455@CP5-2952> <20120601194018.GD5027@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 86AEB9E760 for ; Fri, 1 Jun 2012 13:05:29 -0700 (PDT) In-Reply-To: <20120601194018.GD5027@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Fri, 1 Jun 2012 21:40:18 +0200, Daniel Vetter wrote: > On Wed, May 30, 2012 at 11:28:13AM +0100, Chris Wilson wrote: > > On Wed, 30 May 2012 12:31:56 +0200, Daniel Vetter wrote: > > > Instead of checking for !CPT, check for IBX to make it clearer that > > > this is a IBX-specific workaround. No functional change because we > > > smash the PPT PCH into the HAS_PCH_CPT check and atm DP isn't enabled > > > on the haswell LPT PCH yet. > > > > > > See Bspec Vol 3, Part 3, Section 4.[3-5].1 about DP[BCD], bit 30 for > > > details of this workaround. > > > > > > Signed-Off-by: Daniel Vetter > > Reviewed-by: Chris Wilson > Queued for -next, thanks for the review. Can you also please look at the > other two patches again whether my replies are satisfactory? Sure, the replies were explanation enough to point out my mistake. As always a reminder closer to the code would be useful... -Chris -- Chris Wilson, Intel Open Source Technology Centre