All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Anton Blanchard <anton@samba.org>
Cc: michael@ellerman.id.au, linuxppc-dev@lists.ozlabs.org,
	paulus@samba.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH] powerpc: Fix size of st_nlink on 64bit
Date: Sun, 03 Jun 2012 07:19:29 +1000	[thread overview]
Message-ID: <1338671969.7150.0.camel@pasglop> (raw)
In-Reply-To: <20120602213452.66ba4cbb@kryten>

On Sat, 2012-06-02 at 21:34 +1000, Anton Blanchard wrote:
> commit e57f93cc53b7 (powerpc: get rid of nlink_t uses, switch to
> explicitly-sized type) changed the size of st_nlink on ppc64 from
> a long to a short, resulting in boot failures.
> 
> Signed-off-by: Anton Blanchard <anton@samba.org>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Al, did you CC me on that ? I don't remember seeing it but it could be
my fault...

Cheers,
Ben.

> ---
> 
> Index: linux-build/arch/powerpc/include/asm/stat.h
> ===================================================================
> --- linux-build.orig/arch/powerpc/include/asm/stat.h	2012-06-02 21:25:50.322275743 +1000
> +++ linux-build/arch/powerpc/include/asm/stat.h	2012-06-02 21:26:35.183130538 +1000
> @@ -30,7 +30,7 @@ struct stat {
>  	unsigned long	st_dev;
>  	ino_t		st_ino;
>  #ifdef __powerpc64__
> -	unsigned short	st_nlink;
> +	unsigned long	st_nlink;
>  	mode_t		st_mode;
>  #else
>  	mode_t		st_mode;

  reply	other threads:[~2012-06-02 21:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-02 11:34 [PATCH] powerpc: Fix size of st_nlink on 64bit Anton Blanchard
2012-06-02 21:19 ` Benjamin Herrenschmidt [this message]
2012-06-03  2:28 ` Stephen Rothwell
2012-06-03  3:48   ` Anton Blanchard
2012-06-03  5:30     ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338671969.7150.0.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=anton@samba.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=paulus@samba.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.