From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: hold forcewake around ring hw init Date: Mon, 04 Jun 2012 10:21:14 +0100 Message-ID: <1338801716_475258@CP5-2952> References: <1338799208-22851-1-git-send-email-daniel.vetter@ffwll.ch> <8762b7qwgm.fsf@intel.com> <20120604091604.GB4978@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from fireflyinternet.com (smtp.fireflyinternet.com [109.228.6.236]) by gabe.freedesktop.org (Postfix) with ESMTP id 25B359E7FD for ; Mon, 4 Jun 2012 02:22:04 -0700 (PDT) In-Reply-To: <20120604091604.GB4978@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Jani Nikula Cc: Daniel Vetter , Intel Graphics Development , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 4 Jun 2012 11:16:04 +0200, Daniel Vetter wrote: > On Mon, Jun 04, 2012 at 12:04:41PM +0300, Jani Nikula wrote: > > > > Hi Daniel, please find a couple of comments inline. > > Oops, a clear case of -ENOTENOUGHCOFFEE. Thanks for catching these, I'll > follow up with a v2 shortly. Fwiw, the w/a looks harmless and is indeed advisable in cases where we do a lot of writes (which does not really seem to apply here!) Acked-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Centre