All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: MR Swami Reddy <MR.Swami.Reddy@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	"Deshpande A, Vishwas" <Vishwas.A.Deshpande@ti.com>
Subject: Re: [PATCH v2] ASoC: Support TI Isabelle Audio driver
Date: Mon, 04 Jun 2012 11:49:16 +0100	[thread overview]
Message-ID: <1338806956.15595.3.camel@odin> (raw)
In-Reply-To: <4FCC9280.2090706@ti.com>

Hi Swami,

On Mon, 2012-06-04 at 16:18 +0530, MR Swami Reddy wrote:
> On Monday 04 June 2012 04:05 PM, Mark Brown wrote:
> > On Fri, Jun 01, 2012 at 10:21:54PM +0530, MR.Swami.Reddy@ti.com wrote:
> >
> >>    o Used dev_get_regmap and devm_regmap_init_i2c APIs.
> > This looks mostly good so I've applied it but please send an incremental
> > patch to remove the use of regmap_exit() - the major point of devm_ APIs
> > is that you don't need to explicitly clean things up, removing a class
> > of potential leaks.
> 
> Thank you.
> I will remove the regmap_exit() and send the next patch soon.
> Plz confirm, do I need to send full patch or only removing part for
> regmap_exit()?
> 

Please send an incremental patch. An incremental patch not be the full
driver patch, but will just be the changes for regmap_exit().

Regards

Liam

  reply	other threads:[~2012-06-04 10:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-01 16:51 [PATCH v2] ASoC: Support TI Isabelle Audio driver MR.Swami.Reddy
2012-06-04 10:35 ` Mark Brown
2012-06-04 10:48   ` MR Swami Reddy
2012-06-04 10:49     ` Liam Girdwood [this message]
2012-06-04 10:37 ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2012-06-01 16:49 MR.Swami.Reddy
2012-06-01 16:51 ` Austin, Brian
2012-06-04  5:35   ` MR Swami Reddy
2012-06-01 16:26 MR.Swami.Reddy
2012-06-01 16:44 ` MR Swami Reddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1338806956.15595.3.camel@odin \
    --to=lrg@ti.com \
    --cc=MR.Swami.Reddy@ti.com \
    --cc=Vishwas.A.Deshpande@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.