Re: [PATCH] xl: check for meaningful combination of sedf config file parameters

[Dario Faggioli <raistlin@linux.it>]

[-- Attachment #1.1: Type: text/plain, Size: 1061 bytes --]

On Wed, 2012-06-06 at 11:41 +0100, Ian Jackson wrote:
> Dario Faggioli writes ("[PATCH] xl: check for meaningful combination of sedf config file parameters"):
> > As we do it in the implementation of `xl sched-sedf -d ...', some
> > consistency checking is needed while parsing the sedf scheduling
> > parameters provided via config file. Not doing this results in the call
> > libxl_domain_sched_params_set() to fail, and no parameters being
> > enforced for the domain.
> 
> Why does xl continue after libxl_domain_sched_params_set fails ?
> 
Well, that I really don't know. It has always been like this I guess, it
just print the related error about inconsistent/wrong scheduling
parameters and then the domain is created with default ones.

Should we/I stop it?

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel