From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf/x86: Fix wrmsrl() debug wrapper
Date: Wed, 06 Jun 2012 19:12:27 +0200 [thread overview]
Message-ID: <1339002747.2749.153.camel@twins> (raw)
In-Reply-To: <4FCF8397.6090505@zytor.com>
On Wed, 2012-06-06 at 09:21 -0700, H. Peter Anvin wrote:
> On 06/06/2012 09:15 AM, tip-bot for Peter Zijlstra wrote:
> >
> > perf/x86: Fix wrmsrl() debug wrapper
> >
> > Move the wrmslr() debug wrapper to the common header now that all the
> > include games are gone. Also clean it up a bit to avoid multiple
> > evaluation of the argument.
> >
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Link: http://lkml.kernel.org/n/tip-l4gkfnivwv4yi5mqxjlovymx@git.kernel.org
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
>
> Could you please call this something like trace_wrmsrl() instead of
> silently tacking something onto something else that already had meaning?
Its #if 0, its broken on CONFIG_PARAVIRT etc.. The whole purpose was to
hijack wrmsrl() for perf_event*.c so that I don't have to do
s/wrmsrl/trace_&/ on those files.
Its a crude debug aid, nothing more.
prev parent reply other threads:[~2012-06-06 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 16:15 [tip:perf/core] perf/x86: Fix wrmsrl() debug wrapper tip-bot for Peter Zijlstra
2012-06-06 16:21 ` H. Peter Anvin
2012-06-06 17:12 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339002747.2749.153.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.